GameVersion Images

Bug #786092 reported by Prageeth Silva
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MUGLE
Fix Released
Critical
Prageeth Silva

Bug Description

I just realised that if we are to implement adding a new filed Image for GameVersion, it might not be possible after we do the release on Monday. This is because changing a field in a data persistent object can affect the database and we may loose the data in the process (unless we can port the data).

The solution I can think of is simply have the field already but hide the getter and setter from the client. Once we are ready, we can simply use the getter and setter; this way we have a placeholder for the image in the class structure.

Fortunately this can be easily solved by having the field mapping to a GameFile and when the page is to be displayed with the image, we can simply use the same mechanism to obtain the image.

Does anyone have a better solution, because I just came up with this solution and hasn't spend much time thinking of a proper solution?

Related branches

Revision history for this message
Matt Giuca (mgiuca) wrote :

I was just going to have a database field of type Blob, to store the images, rather than coupling it to the GameFile idea. What do you think?

I think we should come back to this after we have GameFiles working so we have a clear idea of how to treat blobs.

Changed in mugle:
status: New → Triaged
Revision history for this message
Scott Ritchie (sritchie) wrote :

In terms of deployment, this is now critical, but im not sure how to implement it as all the annotations would need to be set for casting between client and server models

Changed in mugle:
assignee: nobody → Prageeth Silva (prageethsilva)
importance: High → Critical
Revision history for this message
Matt Giuca (mgiuca) wrote :

By the way, I am almost 100% sure that you can add fields to a table after deployment. So not that important.

But... we don't need annotations for client/server, etc. It's just going in the database for now. It doesn't need to be exposed at all. Just create a new field of type Blob and set it to null, ought to do it.

Revision history for this message
Scott Ritchie (sritchie) wrote :

Well given that, i've just done a very basic implementation as described above in revision 338

Changed in mugle:
status: Triaged → Fix Committed
Matt Giuca (mgiuca)
Changed in mugle:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.