First Row of File Menu Grid Needs to Stand Out More

Bug #785204 reported by Nat Katin-Borland
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KARL3
Fix Released
Medium
Balazs Ree

Bug Description

The menu row (first row) of the file grid needs to stand out more (see screenshot) - right now it bleeds into the first row of the grid. Can we make it dark gray or something like that?

Tags: r3.62
Revision history for this message
Nat Katin-Borland (nborland) wrote :
Changed in karl3:
assignee: nobody → Balazs Ree (ree)
importance: Undecided → Medium
milestone: none → m56
milestone: m56 → m57
tags: added: multiupload
Revision history for this message
Balazs Ree (ree) wrote :

I will mark this as fixed, because I believe part of the problem was caused by the incorrect alignment of the global selection checkbox.

The grid header now is supposed to be identical with how it behaves on the production trunk. There is a chance that it will not need more fix this way.

If you still believe that we would need to change the styling of the grid, please reopen this issue.

Changed in karl3:
status: New → Fix Committed
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

JimP, please test this on branch3 (https://karlstaging.gocept.com/branch3/osf/) in IE7/IE8/FF3/FF4 and make sure it is fixed. If not, change the status to In Progress and re-assign to Balazs.

Changed in karl3:
assignee: Balazs Ree (ree) → JimPGlenn (jpglenn09)
Revision history for this message
JimPGlenn (jpglenn09) wrote :

This tests fine but Nat may want to see if it up to his question about being darker.

Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Nat, can you test and see if this is looking better?

Changed in karl3:
assignee: JimPGlenn (jpglenn09) → Nat Katin-Borland (nborland)
Revision history for this message
Nat Katin-Borland (nborland) wrote :

The first row of the grid still bleeds into the menu row, so it looks like one giant white bar (see screenshot). I think it would be sufficient if we just thicken the grey border around the menu row and then extend the border along the bottom of the menu as well.

-Nat

Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Back to Balazs

Changed in karl3:
assignee: Nat Katin-Borland (nborland) → Balazs Ree (ree)
status: Fix Committed → In Progress
Changed in karl3:
milestone: m57 → m58
Balazs Ree (ree)
Changed in karl3:
status: In Progress → Triaged
status: Triaged → Fix Committed
Revision history for this message
JimPGlenn (jpglenn09) wrote :

fixed

Changed in karl3:
status: Fix Committed → Fix Released
JimPGlenn (jpglenn09)
tags: added: r3.62
removed: multiupload
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.