Translated string 'pendingmembers' in group.php not read

[Emanuel Garcês]

The translated string 'pendingmembers' in group.php is not being read.
The bug is in the file group\requestjoin.php, line 104 - 109, the current code reads:
'strings' => (object) array(
               'urltext' => (object) array(
                   'key' => 'pendingmembers',
                   'section' => 'group',
               ),
           ),
it should be:
'urltext' => get_string_from_language($adminlang, 'pendingmembers', 'group'),

This is present in Mahara 1.3.6 and the latest 1.4rc1

[Hugh Davenport (hugh-davenport)]

 https://reviews.mahara.org/214

[François Marier (fmarier)]

Hi Emmanuel,

We've tried to reproduce this bug but we haven't been able to :(

Would you be able to take a screenshot of the problem and to tell us exactly on what page you are seeing a bad string?

Thanks,
Francois

[Emanuel Garcês (effgarces)]

Hi. I've only noticed this after finishing the portuguese translation. You need to have another language pack installed so that you can see that this particular string ($string['pendingmembers'], in grou.php) is not being read.
I've not yet installed version 1.4rc to test this, but as I noticed the group.php remained unchanged, I assume that this behaviour still manifests itself

[François Marier (fmarier)]

Thanks for the screenshot Emanuel.

It looks like it's in the "Inbox" area, which is not where we were looking yesterday :)

[Hugh Davenport (hugh-davenport)]

Hi Emmanuel,

I have just tested this with a custom lang pack that has an overwritten pendingmembers string.
This code displays the overwritten string with and without the change you suggested.

It could be that the string is not present in your lang pack. When I tried without that string, it used the site default.

If you could attach the group.php from the lang/xx.utf8/ directory of the lang pack. If it doesn't exist, then there would be your problem.

If it is there, and the group.php does contain the 'pendingmembers' string, could you either attach the full lang pack, or supply a link where we can get it.

Cheers,

Hugh

[Emanuel Garcês (effgarces)]

The 'group.php' is there and has the 'pendingmembers '. I've attached the language pack, so that you can test it.
I just installed version 1.4 and sure enough the string is appearing correctly, but in version 1.3.x, the one we are using, the problem still manifests.

[Hugh Davenport (hugh-davenport)]

Hi Emanuel,

I have just tested your pack against master and 1.3_STABLE in the git
tree. Both seem to work as expected, so not sure whats up. If it works
for you in 1.4 then we shall leave it at that.

Cheers,

Hugh

On 24/05/11 20:22, Emanuel Garcês wrote:
> The 'group.php' is there and has the 'pendingmembers '. I've attached the language pack, so that you can test it.
> I just installed version 1.4 and sure enough the string is appearing correctly, but in version 1.3.x, the one we are using, the problem still manifests.
>
> ** Attachment added: "langpack-pt.tgz"
> https://bugs.launchpad.net/mahara/+bug/785068/+attachment/2140608/+files/langpack-pt.tgz
>

--
Hugh Davenport
803 2258
Developer
Catalyst Ltd.