Services_Libravatar

SRV handling of weight and priority is complicated

Bug #785022 reported by François Marier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Services_Libravatar
Fix Committed
High
Melissa Draper

Bug Description

It looks like the priority is handled correctly, but the weight attribute is more of a statistical thing (see RFC2782 weight ordering algorithm on page 3 for the gory details).

You can probably just copy the code from the Perl module (srv_hostname function):

  http://cpansearch.perl.org/src/FMARIER/Gravatar-URL-1.04/lib/Libravatar/URL.pm

Melissa Draper (melissa)
Changed in services-libravatar:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Melissa Draper (melissa) wrote :

Does https://gitorious.org/services_libravatar/services_libravatar/blobs/master/Services/Libravatar.php#line314 look approximately correct to you?

Revision history for this message
Melissa Draper (melissa) wrote :

Actually, https://gitorious.org/services_libravatar/services_libravatar/blobs/38fdf9037199e11672ad8fb8b7665600f8273951/Services/Libravatar.php#line314 is a better link, it won't change.

Melissa Draper (melissa)
Changed in services-libravatar:
status: Confirmed → In Progress
assignee: nobody → Melissa Draper (melissa)
Revision history for this message
François Marier (fmarier) wrote :

As far as I can tell, it should work.

At least, I can't easily see anything wrong with your code.

Melissa Draper (melissa)
Changed in services-libravatar:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.