database import policy violation in ftpmaster

[Elliot Murphy]

snip from a run of some page tests:

** 1 import policy violations **

There were 1 database import violations.
You should not import canonical.launchpad.database.publishing into:
    canonical.launchpad.scripts.ftpmaster
Exception exceptions.TypeError: "'NoneType' object is not callable" in <bound method Transaction.__del__ of <sqlobject.dbconnection.Transaction object at 0x2b3a0b545590>> ignored

I don't know enough about ftpmaster to suggest a fix for this, so reporting a bug instead.

[Celso Providelo (cprov)]

Yes, we are still using an special query on SPFP to get unique librarian file reference for a given filename (SyncSource.fetchFileFromLIbrarian).

It can be replaced by matching the wanted API with the already available method IDistribution (getFileByName).

[Celso Providelo (cprov)]

Hi Elliot,

Thanks for the report, let's get it fixed, hopefully, next Friday.

[Celso Providelo (cprov)]

Steve also suggested that when this problem is fixed, the import fascist should also disallow future such imports, by causing an exception and not just a warning.
I will hopefully address it tomorrow morning.

[Celso Providelo (cprov)]

wip in my `dak-tools`.

[Celso Providelo (cprov)]

RF 4393