SRU: Banshee bugfix release

[Chow Loong Jin]

  affects ubuntu/banshee
  status fixreleased

  affects ubuntu/natty/banshee
  status inprogress

  subscribe ubuntu-sru

Banshee has a bugfix release, 2.0.1, which is already in Oneiric. The relevant
changelog entries are:

banshee (2.0.1-1ubuntu1) oneiric; urgency=low

  * [327a8d2] Merge from Debian Unstable, remaining changes:
    + Enable SoundMenu and Disable NotificationArea by default
    + Disable boo and karma extensions
    + Enable and recommnd u1ms and soundmenu extensions
    + Move desktop file for Meego UI to /usr/share/une/applications
    + Change the url for the Amazon store redirector
    + Create the U1MS widget earlier and bump libu1 requirement
  * [2ca3f6a] Refresh 90_amazon_url.patch

 -- Chow Loong Jin <email address hidden> Fri, 06 May 2011 17:00:03 +0800

banshee (2.0.1-1) unstable; urgency=low

  * [5f2e8a7] Switch over to bz2 in debian/watch
  * [5dcec7d] New upstream release:
    + AmazonMp3.Store: Fix signed-in detection for UK store
    + PodcastFeedPropertiesDialog: Fix display of feed URL (underscore)
    + bgo#648941: Add .spc to whitelist
    + bgo#648458: PlsPlaylistFormat: Make parsing the header case+insensitive
    + bgo#647754: Add USB ids for Xperia X12
    + bgo#647024: Lastfm: Fix NRE crash
    + bgo#646991: AlbumListView: Fix disappearing option in Preferences
    + bgo#647932: DatabaseSource: Fix NRE in SkipTrackIfRemoved
    + bgo#642140: Last.fm: Close HTTP streams when finished with them
    + bgo#633552: AppleDevice: Ensure m4a/mp3 are supported
    + bgo#647144: StreamPositionLabel: Avoid unnecessary redraws
    + bgo#647089: Daap: Bind to IPAddress.Loopback instead of Any (LP: #753986)
    + bgo#647059: Fix Remote Daap crash
  * [5bd47d1] Drop upstreamed 10_bind-to-loopback-for-daap
  * [a853ad8] Drop upstreamed 11_reduce_cpu_usage.patch

 -- Chow Loong Jin <email address hidden> Tue, 03 May 2011 21:42:30 +0800

--
Kind regards,
Loong Jin

[Clint Byrum (clint-fewbar)]

Hello Chow. I cannot accept your upload to natty-proposed given our current SRU process.

https://wiki.ubuntu.com/StableReleaseUpdates

The process requires that stable release updates are minimally invasive, and that the bugs fixed have clear test cases. The sheer size of the patch is much too big to accept, and the bugs fixed are all upstream and not listed in Launchpad at all.

I wonder if Banshee would qualify for a Micro Release Exception

https://wiki.ubuntu.com/StableReleaseUpdates/MicroReleaseExceptions

That may be a better way to go if there will be similar upstream bug fix releases at a regular pace.

[Martin Pitt (pitti)]

The SRU microrelease exception has now been granted, so this can proceed

[Martin Pitt (pitti)]

Hello Chow, or anyone else affected,

Accepted banshee into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Doug McMahon (mc3man)]

Not sure how well this was tested or if it was even applied to banshee (2.0.0-2ubuntu2) but if so the performance is quite poor
(there is no mention in changelog of this fix
Anyway, taking a rep sample of 12 cd's of various types (popular, obscure, multi-disks, ect. only got success on 4 of 12

As a comparison applying the 'orig' patch to the pre SRU and post SRU source got a 100% success rate

This also applies to the current 11.10 banshee - exact same results
for the heck of it will report a bug on 11.10 (banshee-2.1.0, take it as you may..
For reference will attach patch I've applied, named it for applying purposes, this was one used on 11.10, same for 11.04 (offset -2

[Doug McMahon (mc3man)]

Just to note - on natty the changelog in synaptic does mention , not so in the source, anyway this is the version that is installed and that tested poorly on natty

banshee (2.0.1-1ubuntu1~natty2) natty-proposed; urgency=low

  * Re-upload after MicroRelease Exception approval

 -- Chow Loong Jin <email address hidden> Sat, 02 Jul 2011 10:05:47 +0800

[Chow Loong Jin (hyperair)]

On 20/07/2011 04:19, Doug McMahon wrote:
> Not sure how well this was tested or if it was even applied to banshee (2.0.0-2ubuntu2) but if so the performance is quite poor
> (there is no mention in changelog of this fix
> Anyway, taking a rep sample of 12 cd's of various types (popular, obscure, multi-disks, ect. only got success on 4 of 12
>
> As a comparison applying the 'orig' patch to the pre SRU and post SRU
> source got a 100% success rate
>
> This also applies to the current 11.10 banshee - exact same results
> for the heck of it will report a bug on 11.10 (banshee-2.1.0, take it as you may..
> For reference will attach patch I've applied, named it for applying purposes, this was one used on 11.10, same for 11.04 (offset -2
>
> ** Patch added: "cd_info.patch"
> https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/784179/+attachment/2218964/+files/cd_info.patch
>

Could you file a new bug with this patch and with the exact problem description
please? Your post isn't exactly very clear about what the issue is, and this bug
is not meant to be a dumping ground for other bugs found in a release.

--
Kind regards,
Loong Jin

[Doug McMahon (mc3man)]

Sure but a few things -
This report is is a fix released from here - Bug #778090 which is about the inability of banshee to retrieve cd info from musicbrainz
Comment 3 here suggests that the banshee upgrade in natty-proposed contains bug fixes, the assumption would be that the cd retrieval issue 'fix' was included

I'm simply reporting that in a test of 12 cd's that the banshee package in natty-proposed performed poorly, was only successful in 4 out of the 12.
So if banshee (2.0.1-1ubuntu1~natty2) natty-proposed; was supposed to fix this particular issue than it hasn't, if it wasn't intended to be fixed then Bug #778090 should not show a fix released pointing to here.
Further I'm reporting that with the attached patch applied banshee is then 100% successful with same 12 cd test group

As far as the patch - it's your (banshee's) patch, I retrieved it from a commit to master some time ago
When I saw how poorly banshee (2.0.1-1ubuntu1~natty2) was performing I apt-get'ed the source to see if it had been applied which obviously it hadn't.

So while I'll file a bug on the current banshee in 11.10 which performs just as poorly as natty-proposed I fail to see what I'm "dumping" here. Banshee in natty-proposed is unable to retrieve cd info reliably

[Chow Loong Jin (hyperair)]

On 20/07/2011 12:18, Doug McMahon wrote:
> Sure but a few things -
> This report is is a fix released from here - Bug #778090 which is about the inability of banshee to retrieve cd info from musicbrainz
> Comment 3 here suggests that the banshee upgrade in natty-proposed contains bug fixes, the assumption would be that the cd retrieval issue 'fix' was included
>
> I'm simply reporting that in a test of 12 cd's that the banshee package in natty-proposed performed poorly, was only successful in 4 out of the 12.
> So if banshee (2.0.1-1ubuntu1~natty2) natty-proposed; was supposed to fix this particular issue than it hasn't, if it wasn't intended to be fixed then Bug #778090 should not show a fix released pointing to here.
> Further I'm reporting that with the attached patch applied banshee is then 100% successful with same 12 cd test group
>
> As far as the patch - it's your (banshee's) patch, I retrieved it from a commit to master some time ago
> When I saw how poorly banshee (2.0.1-1ubuntu1~natty2) was performing I apt-get'ed the source to see if it had been applied which obviously it hadn't.
>
> So while I'll file a bug on the current banshee in 11.10 which performs
> just as poorly as natty-proposed I fail to see what I'm "dumping" here.
> Banshee in natty-proposed is unable to retrieve cd info reliably
>

Ah, then the information (and patch) should go to that bug instead. Does the
patch work for you?

--
Kind regards,
Loong Jin

[Doug McMahon (mc3man)]

Chow Loong Jin (hyperair) wrote >
Ah, then the information (and patch) should go to that bug instead. Does the
patch work for you?

Works quite fine here - as mentioned 100% on a test on 12 cd's
This is on both Natty's and Oneiric's respective versions of banshee, the patch is the same just a -2 offset for natty's source.

I'm still unclear on whether this issue was thought to have been fixed as part of this SRU, that's why I commented here.
i'll just go ahead and file on Oneiric

[Rolf Leggewie (r0lf)]

natty has seen the end of its life and is no longer receiving any updates. Marking the natty task for this ticket as "Won't Fix".