account_move_line: improved account selection when partner changes

[Stéphane Bidoul (Acsone)]

Hi,

When one create journal entries in journals of type 'general', the system does not propose an account when a partner is selected. For other journal types such as 'sale' and 'purchase', an account is proposed when a partner is selected.

The attached patch improves this behaviour as an attempt to solve the FIXME in that area of account_move_line.

Additionnally it removes the test on journal_type = 'expense' (expense not being a known journal type).

Best regards,

-sbi

[Ashvin Rathod (OpenERP) (ara-tinyerp)]

Hello Stéphane,

I have tested as your description and get the same problem. And your attached patch is working fine for this. It will be merged soon in trunk addons.

Revision ID: <email address hidden>
Revision No: 4769

Thanks for contribution.

[Stéphane Bidoul (Acsone) (sbi)]

Hi,

Please not that your proposed merge does not reflect my patch entirely.

IMO, the last else should really be "elif not part.customer and part.supplier", because if a partner is both customer and partner you can't propose a meaningful account.

Best regards,

-sbi

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

I agree with Stephane we should keep elif instead of else.

Thanks Stephane for your contribution,
mra

[qdp (OpenERP) (qdp)]

fix released in revision 5082 of trunk addons