Mixxx

played counter counting loads, not playes

Bug #783634 reported by Daniel Schürmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Daniel Schürmann
Mixxx 1.11.0

Bug Description

The played counter is incremented when a track is loaded to the deck. It should be incremented when the track is played to to master output. Today we have a distortion in played counter if we load tracks for headphones preview.
(trunk version)

Tags: library

Related branches

lp:~daschuer/mixxx/daschuers_trunk
lp:~daschuer/mixxx/features_setlog
Mixxx Development Team: Pending requested
Diff: 2721 lines (+1490/-224)
32 files modified
mixxx/build/depends.py (+26/-4)
mixxx/lib/soundtouch-1.6.0/STTypes.h (+1/-1)
mixxx/res/html/setlogs.html (+10/-0)
mixxx/res/mixxx.qrc (+3/-0)
mixxx/src/basetrackplayer.cpp (+1/-1)
mixxx/src/dlgautodj.cpp (+1/-1)
mixxx/src/library/cratefeature.cpp (+106/-82)
mixxx/src/library/cratefeature.h (+4/-1)
mixxx/src/library/dao/cratedao.cpp (+5/-4)
mixxx/src/library/dao/cratedao.h (+3/-1)
mixxx/src/library/dao/playlistdao.cpp (+143/-29)
mixxx/src/library/dao/playlistdao.h (+23/-5)
mixxx/src/library/legacylibraryimporter.cpp (+1/-2)
mixxx/src/library/library.cpp (+2/-0)
mixxx/src/library/libraryfeature.h (+2/-1)
mixxx/src/library/parser.cpp (+1/-1)
mixxx/src/library/parsercsv.cpp (+238/-0)
mixxx/src/library/parsercsv.h (+41/-0)
mixxx/src/library/playlistfeature.cpp (+113/-57)
mixxx/src/library/playlistfeature.h (+5/-1)
mixxx/src/library/playlisttablemodel.cpp (+12/-0)
mixxx/src/library/playlisttablemodel.h (+1/-0)
mixxx/src/library/preparefeature.cpp (+13/-2)
mixxx/src/library/setlogfeature.cpp (+571/-0)
mixxx/src/library/setlogfeature.h (+93/-0)
mixxx/src/library/sidebarmodel.cpp (+50/-26)
mixxx/src/library/sidebarmodel.h (+1/-1)
mixxx/src/library/trackcollection.cpp (+1/-1)
mixxx/src/mixxx.cpp (+1/-1)
mixxx/src/trackinfoobject.cpp (+11/-2)
mixxx/src/trackinfoobject.h (+2/-0)
mixxx/src/widget/wlibrarysidebar.cpp (+5/-0)
jus (jus)
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → Daniel Schürmann (daschuer)
status: Confirmed → In Progress
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Bug is solved in lp:~daschuer/mixxx/daschuers_trunk by the setlog (history) feature.

Revision history for this message
Sean M. Pappalardo (pegasus-renegadetech) wrote :

I just wanted to point out that there is already some good logic for determining when a song is playing that Phillip Whelan (Madjester) wrote for the shoutcast metadata feature. This code is in the 1.9 branch and onward. I haven't looked at your code yet, but if you haven't made use of this logic, please do, so we can have a single object used across Mixxx that determines if and what deck is playing.

RJ Skerry-Ryan (rryan)
tags: added: library
Revision history for this message
Daniel Schürmann (daschuer) wrote :

I do use the PlayerInfo Class introduced by Phillip Whelan.

In my current solution, the setlogfeature is connected to the valueChanged Signal of "playposition" to calculate the current playing track using the PlayerInfo Class.

Eniginerecord and shoutcast are also continuously calculating what audience is listening.

It looks like a good idea, to let only one class calculate this and emit a signal when the current playing track is changed. I am not sure what is the right thread for this work and what is the outcome for enginerecord and shoutcast. For now, I am satisfied with the current solution.

Daniel Schürmann (daschuer)
Changed in mixxx:
status: In Progress → Fix Committed
milestone: none → 1.11.0
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5898

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.