add user page ignores quota entered by admin

[Hugh Davenport]

in admin/users/add.php

if you specify a quota different from the default, it gets ignored and the default quota is used instead.

[Hugh Davenport (hugh-davenport)]

Actually it is bigger than this, the quota field in this page is ignored, and only sets it to the default setting...

Fix at https://reviews.mahara.org/172

[Hugh Davenport (hugh-davenport)]

Fix above doesn't actually check against max size, if a quota above maximum is given, that value is used, when it shouldn't (it should complain)

[François Marier (fmarier)]

Thanks for the patch Hugh.

I don't think we need to check that the quota is within the limit here. It's the admin adding the user account and they should probably be able to exceed the limit if they want to.

[Hugh Davenport (hugh-davenport)]

Hi Francois,

I was thinking that the limit may be needed, as if you are not the site
admin, but just an inst. admin, then you /shouldn't/ be able to override
the max setting. It could be that part of what I do is enforce it for
inst. admins only, and site admins get away with it.

Cheers,

Hugh

[François Marier (fmarier)]

That's a good point. Institutional admins should probably not be able to exceed that limit.

Can you create a new bug for it? I'll rename this one to cover what your patch has already fixed.