PBXT

free() of memory containing active spinlock

Bug #782433 reported by Vladislav Vaintroub
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MariaDB
Fix Released
Medium
Vladislav Vaintroub
MariaDB 5.2
PBXT
Fix Committed
Undecided
Vladimir Kolesnikov

Bug Description

xt_heap_release() does not release spinlock hp->h_lock that is initialized in xt_heap_new().

This makes Windows application verifier unhappy.

Fix:
--- storage/pbxt/src/heap_xt.cc 2009-11-24 10:55:06 +0000
+++ storage/pbxt/src/heap_xt.cc 2011-05-13 17:03:23 +0000
@@ -109,6 +109,7 @@
    if (hp->h_finalize)
     (*hp->h_finalize)(self, hp);
    xt_spinlock_unlock(&hp->h_lock);
+ xt_spinlock_free(NULL, &hp->h_lock);
    xt_free(self, hp);
    return;
   }

Related branches

lp:~vkolesnikov/pbxt/pbxt-maria-windows-app-ver-fixes
On hold for merging into lp:pbxt
PBXT Core: Pending requested
Diff: 171 lines (+22/-9)
9 files modified
src/cache_xt.cc (+5/-0)
src/discover_xt.cc (+1/-1)
src/ha_pbxt.cc (+2/-2)
src/heap_xt.cc (+1/-0)
src/lock_xt.cc (+5/-0)
src/lock_xt.h (+1/-0)
src/table_xt.cc (+6/-4)
src/xaction_xt.cc (+0/-1)
src/xt_defs.h (+1/-1)
Revision history for this message
Vladislav Vaintroub (wlad-montyprogram) wrote :

Fixed in MariaDB 5.2.7

Changed in maria:
assignee: nobody → Vladislav Vaintroub (wlad-montyprogram)
importance: Undecided → Medium
milestone: none → 5.2
status: New → Fix Released
Vladimir Kolesnikov (vkolesnikov)
Changed in pbxt:
assignee: nobody → Vladimir Kolesnikov (vkolesnikov)
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.