TagPlayer doesn't start

Bug #781638 reported by vovkkk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
TagPlayer
Fix Released
High
filipe

Bug Description

I played with version 0.2.09-daily~r59~natty1
I added new folders for more songs and everything worked fine: playing, searching, highlighting etc.
I noticed that TagPlayer used about 10-15% CPU — I thought that's okay it scanning my ~6000 songs.
But after 40 mins it still used about 10-15% CPU. And even after restarting and some time still 10-15% CPU.
Then I noticed that TagPlayer doesn't see some songs, for example, Britny Spears (hey, don't luaghing) — I choose pop tag and pressing next for many times (keep in mind I have very small number of pop songs).
In this case progress bar for adding files to library would be helpful.
There was nothing in terminal.

Then closed TagPlayer and went to do some things.
And then after some time launching the app again and again 10-15% CPU and no Britny Spears.
I decided delete everything: ~/tagplayer* and db from couchdb, to start from scratch.
Launched TagPlayer, added all my music from /media/MUF/Музыка (NTFS partition with mp3's, ogg's, flac's and even wma's) waiting some time while the app scanning folders.
Restart the app and get this:

$ LANG=C tagplayer
Traceback (most recent call last):
  File "/usr/bin/tagplayer", line 310, in <module>
    window = TagplayerWindow()
  File "/usr/bin/tagplayer", line 90, in __new__
    new_object.finish_initializing(builder)
  File "/usr/bin/tagplayer", line 141, in finish_initializing
    self.__init_taglib()
  File "/usr/bin/tagplayer", line 239, in __init_taglib
    self.taglib = taglib.TagLib(self.preferences['music_dir'])
  File "/usr/lib/pymodules/python2.7/tagplayer/daemon/taglib.py", line 39, in __init__
    if os.path.isdir(x):
  File "/usr/lib/python2.7/genericpath.py", line 41, in isdir
    st = os.stat(s)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 11-16: ordinal not in range(128)

and the same error without LANG=C, my language is Russian if it matters.

Revision history for this message
filipe (hikibi) wrote :

Ok, let me answer separately:

- The ~15% CPU TagPlayer uses is normal and to be expected, it's mostly due to the playback, compare it with banshee and you'll see it's not at all a bad number...

- TagPlayer uses Last.fm info, which means, if a song isn't recognized by Last.fm (usually because of incomplete or wrong metadata on the song file) then TagPlayer won't keep in it's library, since it can neither identify it or assign it tags. That's probably what's happening with the songs you're not getting, check it's IDv3 metadata to see if it's correct. Still, this type of situations would be much easily debbuged if TagPlayer had some sort of debugging option, so I'll work on that.

- Python 2.x has a lot of problems with unicode encoding because some of its inner libraries are not ready to deal with it.. This type of errors is especially obvious for people whose language have non-ascii symbols, such as russian (i'm portuguese, so I have the same issue very often). In this case though, I only get that error when I use tagplayer with LANG=C, with utf8 locales that doesn't happen ( I even used a similarly named directory with cyrillic and greek characters to test ).

without the LANG=C prefix do you get any kind of error in the terminal?

Changed in tagplayer:
status: New → Incomplete
Revision history for this message
vovkkk (vovkkk) wrote :

Yes, TagPlayer started without the LANG=C prefix. I understand my mistake.

I checked metadata and it's correct (see screenshot and compare with http://www.lastfm.com.br/music/Britney+Spears/_/I+Wanna+Go/+tags?setlang=pt)
I remove from library all music and add only one album of Britney Spears.
After that TagPlayer start without the LANG=C prefix, but there are no any tags in library.
Also I noticed same situation with other ogg files and flac and m4a, it are Killers, Red Hot Chili Peppers, The Bloodhound Gang and others.

> compare it with banshee and you'll see it's not at all a bad number...
Hm, honestly, banshee uses 1-3% CPU while the playback on my computer, i can make screencast to prove it.

filipe (hikibi)
Changed in tagplayer:
status: Incomplete → Confirmed
Revision history for this message
filipe (hikibi) wrote :

Ogg, flac and m4a were being filtered out, sorry.
I have included them now (fix will be on r60), although it's not working correctly with m4a most times (I will try to fix it later).

Changed in tagplayer:
status: Confirmed → Fix Committed
importance: Undecided → High
assignee: nobody → filipe (hikibi)
filipe (hikibi)
Changed in tagplayer:
milestone: none → 0.2.09
filipe (hikibi)
Changed in tagplayer:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.