server_detect incorrectly thinks drizzle built in May is MySQL

Bug #781472 reported by Stewart Smith
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Drizzle
Fix Released
Critical
Stewart Smith

Bug Description

<stewart> boost::regex mysql_regex("(5\\.[0-9]+\\.[0-9]+)");
       boost::regex drizzle_regex("(20[0-9]{2}\\.(0[1-9]|1[012])\\.[0-9]+)");
 and....
 (gdb) p version
 $6 = {static npos = <optimized out>,
   _M_dataplus = {<std::allocator<char>> = {<__gnu_cxx::new_allocator<char>> = {<No data fields>}, <No data fields>}, _M_p = 0x6858d8 "2011.05.17.2308"}}
 mtaylor, i.e. the mysql regex matches :)

Related branches

Revision history for this message
Stewart Smith (stewart) wrote :

we get failures such as:
main.drizzle_client [ fail ]
--- /ssd/drizzle/working/tests/r/drizzle_client.result 2011-05-11 13:54:50.892823000 +0300
+++ /ssd/drizzle/working/tests/r/drizzle_client.reject 2011-05-11 18:27:54.806908265 +0300
@@ -40,9 +40,9 @@
 i j k
 NULL 1 NULL
 Field Type Null Default Default_is_NULL On_Update
-i INTEGER YES YES
-j INTEGER NO NO
-k INTEGER YES YES
+i INTEGER 1 1
+j INTEGER 0 0
+k INTEGER 1 1
 +------+---+------+
 | i | j | k |
 +------+---+------+
@@ -51,9 +51,9 @@
 +-------+---------+------+---------+-----------------+-----------+
 | Field | Type | Null | Default | Default_is_NULL | On_Update |
 +-------+---------+------+---------+-----------------+-----------+
-| i | INTEGER | YES | | YES | |
-| j | INTEGER | NO | | NO | |
-| k | INTEGER | YES | | YES | |
+| i | INTEGER | 1 | | 1 | |
+| j | INTEGER | 0 | | 0 | |
+| k | INTEGER | 1 | | 1 | |
 +-------+---------+------+---------+-----------------+-----------+
 i s1
 1 x
@@ -75,13 +75,13 @@
 +-------------+
 create table t1(a int, b varchar(255), c int);
 Field Type Null Default Default_is_NULL On_Update
-a INTEGER YES YES
-b VARCHAR YES YES
-c INTEGER YES YES
+a INTEGER 1 1
+b VARCHAR 1 1
+c INTEGER 1 1
 Field Type Null Default Default_is_NULL On_Update
-a INTEGER YES YES
-b VARCHAR YES YES
-c INTEGER YES YES
+a INTEGER 1 1
+b VARCHAR 1 1
+c INTEGER 1 1
 drop table t1;
 1
 1

Stewart Smith (stewart)
Changed in drizzle:
status: Confirmed → Fix Committed
Stewart Smith (stewart)
Changed in drizzle:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.