/usr/share/shorewall/wait4ifup does not work when dash is /bin/sh

[Debian Bug Importer]

Automatically imported from Debian bug report #270327 http://bugs.debian.org/270327

[Debian Bug Importer (debzilla)]

Automatically imported from Debian bug report #270327 http://bugs.debian.org/270327

[Debian Bug Importer (debzilla)]

Message-Id: <email address hidden>
Date: Mon, 06 Sep 2004 22:07:23 +0200
From: Paul Wagland <email address hidden>
To: Debian Bug Tracking System <email address hidden>
Subject: /usr/share/shorewall/wait4ifup does not work when dash is /bin/sh

Package: shorewall
Severity: serious
Justification: Policy 10.4

According to section 10.4, any script that calls /bin/sh should only use
POSIX features. Line 22 of /usr/share/shorewall/wait4ifup has the
following:

$((start+timeout))

I believe that this is a bash extension, the 'proper' way to do this is
the following:

$(($start+$timeout))

I have done this, and this script now runs properly with dash as well as
bash.

Hope this helps,
Cheers,
Paul

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.8-1-k7
Locale: LANG=C, LC_CTYPE=C

[Lorenzo Martignoni (lorenzo-martignoni)]

* Paul Wagland <email address hidden>:
> Package: shorewall
> Severity: serious
> Justification: Policy 10.4
>
> According to section 10.4, any script that calls /bin/sh should only use
> POSIX features. Line 22 of /usr/share/shorewall/wait4ifup has the
> following:
>
> $((start+timeout))
>
> I believe that this is a bash extension, the 'proper' way to do this is
> the following:
>
> $(($start+$timeout))
>
> I have done this, and this script now runs properly with dash as well as
> bash.

Thank you for your report. It will be fixed in the next release of the
package.

-- lorenzo

[Debian Bug Importer (debzilla)]

Message-ID: <email address hidden>
Date: Mon, 6 Sep 2004 22:39:43 +0200
From: Lorenzo Martignoni <email address hidden>
To: Paul Wagland <email address hidden>, <email address hidden>
Subject: Re: Bug#270327: /usr/share/shorewall/wait4ifup does not work when dash is /bin/sh

* Paul Wagland <email address hidden>:
> Package: shorewall
> Severity: serious
> Justification: Policy 10.4
>
> According to section 10.4, any script that calls /bin/sh should only use
> POSIX features. Line 22 of /usr/share/shorewall/wait4ifup has the
> following:
>
> $((start+timeout))
>
> I believe that this is a bash extension, the 'proper' way to do this is
> the following:
>
> $(($start+$timeout))
>
> I have done this, and this script now runs properly with dash as well as
> bash.

Thank you for your report. It will be fixed in the next release of the
package.

-- lorenzo

[Fabio Massimo Di Nitto (fabbione)]

Fixed in shorewall_2.0.2-4ubuntu1.

[Lorenzo Martignoni (lorenzo-martignoni)]

Source: shorewall
Source-Version: 2.0.8-4

We believe that the bug you reported is fixed in the latest version of
shorewall, which is due to be installed in the Debian FTP archive:

shorewall_2.0.8-4.diff.gz
  to pool/main/s/shorewall/shorewall_2.0.8-4.diff.gz
shorewall_2.0.8-4.dsc
  to pool/main/s/shorewall/shorewall_2.0.8-4.dsc
shorewall_2.0.8-4_all.deb
  to pool/main/s/shorewall/shorewall_2.0.8-4_all.deb

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Lorenzo Martignoni <email address hidden> (supplier of updated shorewall package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 12 Sep 2004 20:40:27 +0200
Source: shorewall
Binary: shorewall
Architecture: source all
Version: 2.0.8-4
Distribution: unstable
Urgency: high
Maintainer: Lorenzo Martignoni <email address hidden>
Changed-By: Lorenzo Martignoni <email address hidden>
Description:
 shorewall - Shoreline Firewall (Shorewall)
Closes: 268854 268855 268858 268859 268860 268862 270327
Changes:
 shorewall (2.0.8-4) unstable; urgency=high
 .
   * The wait4ifup script now uses only POSIX features (closes:#270327)
 .
 shorewall (2.0.8-3) unstable; urgency=low
 .
   * Added action to allow Subversion traffic (closes: #268858)
   * Added action to allow CVS pserver traffic (closes: #268855)
   * Added action to allow MySQL traffic (closes: #268859)
   * Added action to allow PostrgreSQL traffic (closes: #268860)
   * Added action to allow Rsync traffic (closes: #268862)
   * Added action to allow Distributed Compiler traffic (closes: #268854)
Files:
 4cd8b2b28c4397f25c4c6b3a5eff7b2e 656 net optional shorewall_2.0.8-4.dsc
 2ef0dcfbe8afa0424dce4697ba0a50e6 27056 net optional shorewall_2.0.8-4.diff.gz
 84e3e00ed4263a765ba1f0c439f6f1a9 112404 net optional shorewall_2.0.8-4_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBRoNXStlRaw+TLJwRAjgtAJwOXqxSA9sG6KgxTPBbnzAmIQzynACeKqjt
BjyAGIfOdI9Y0Gy3NPt9WNQ=
=QQHb
-----END PGP SIGNATURE-----

[Debian Bug Importer (debzilla)]

Message-Id: <email address hidden>
Date: Tue, 14 Sep 2004 01:47:16 -0400
From: Lorenzo Martignoni <email address hidden>
To: <email address hidden>
Subject: Bug#270327: fixed in shorewall 2.0.8-4

Source: shorewall
Source-Version: 2.0.8-4

We believe that the bug you reported is fixed in the latest version of
shorewall, which is due to be installed in the Debian FTP archive:

shorewall_2.0.8-4.diff.gz
  to pool/main/s/shorewall/shorewall_2.0.8-4.diff.gz
shorewall_2.0.8-4.dsc
  to pool/main/s/shorewall/shorewall_2.0.8-4.dsc
shorewall_2.0.8-4_all.deb
  to pool/main/s/shorewall/shorewall_2.0.8-4_all.deb

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Lorenzo Martignoni <email address hidden> (supplier of updated shorewall package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 12 Sep 2004 20:40:27 +0200
Source: shorewall
Binary: shorewall
Architecture: source all
Version: 2.0.8-4
Distribution: unstable
Urgency: high
Maintainer: Lorenzo Martignoni <email address hidden>
Changed-By: Lorenzo Martignoni <email address hidden>
Description:
 shorewall - Shoreline Firewall (Shorewall)
Closes: 268854 268855 268858 268859 268860 268862 270327
Changes:
 shorewall (2.0.8-4) unstable; urgency=high
 .
   * The wait4ifup script now uses only POSIX features (closes:#270327)
 .
 shorewall (2.0.8-3) unstable; urgency=low
 .
   * Added action to allow Subversion traffic (closes: #268858)
   * Added action to allow CVS pserver traffic (closes: #268855)
   * Added action to allow MySQL traffic (closes: #268859)
   * Added action to allow PostrgreSQL traffic (closes: #268860)
   * Added action to allow Rsync traffic (closes: #268862)
   * Added action to allow Distributed Compiler traffic (closes: #268854)
Files:
 4cd8b2b28c4397f25c4c6b3a5eff7b2e 656 net optional shorewall_2.0.8-4.dsc
 2ef0dcfbe8afa0424dce4697ba0a50e6 27056 net optional shorewall_2.0.8-4.diff.gz
 84e3e00ed4263a765ba1f0c439f6f1a9 112404 net optional shorewall_2.0.8-4_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBRoNXStlRaw+TLJwRAjgtAJwOXqxSA9sG6KgxTPBbnzAmIQzynACeKqjt
BjyAGIfOdI9Y0Gy3NPt9WNQ=
=QQHb
-----END PGP SIGNATURE-----