Odoo Addons (MOVED TO GITHUB)

account_anglo_saxon - field positioning and code simplification

Bug #778487 reported by Ferdinand
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
OpenERP R&D Addons Team 3
Odoo Addons (MOVED TO GITHUB) 6.1

Bug Description

1) property_account_creditor_price_difference must be placed in the "Purchase Property" columns

2) IMHO "product_tmpl_id" is not necessary
 - oa = ol.product_id.product_tmpl_id.property_stock_account_input and ol.product_id.product_tmpl_id.property_stock_account_input.id
+ oa = ol.product_id.property_stock_account_input and ol.product_id.property_stock_account_input.id

Related branches

lp:~openerp-dev/openobject-addons/trunk-bug-778487-ara
Mustufa Rangwala (Open ERP) (community): Approve
qdp (OpenERP): Pending requested
Diff: 207 lines (+34/-33)
3 files modified
account_anglo_saxon/invoice.py (+31/-31)
account_anglo_saxon/product_view.xml (+2/-1)
account_anglo_saxon/purchase.py (+1/-1)
Revision history for this message
Ferdinand (office-chricar) wrote :
Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Dr Ferdinand,

I have checked your issue.
This is not a bug but it's coding improvement.

So better to team will decided on this.

That's why I am set it as a "Triaged" and the related team takes the decision on it.

Thanks for the understanding!

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Low
status: New → Triaged
Ashvin Rathod (OpenERP) (ara-tinyerp)
Changed in openobject-addons:
status: Triaged → Confirmed
Ashvin Rathod (OpenERP) (ara-tinyerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Ashvin Rathod (OpenERP) (ara-tinyerp) wrote :

Hello Ferdinand,

I have tested your patch and its working fine for this.
It will be merged soon in trunk addons.

Revision ID: <email address hidden>
Revision No: 4686

Thanks for participation !

Changed in openobject-addons:
status: In Progress → Fix Committed
Mustufa Rangwala (Open ERP) (mra-tinyerp)
Changed in openobject-addons:
milestone: none → 6.1
Fabien (Open ERP) (fp-tinyerp)
Changed in openobject-addons:
status: Fix Committed → Fix Released
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

The patch (credited to you) was merged in trunk at revision 5038 revid:<email address hidden>, thanks for your excellent contribution!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.