InvalidURL opening branch with non-ascii characters from repository view

[Jelmer Vernooij]

I'm using Bazaar Explorer 1.1.2 with bzr 2.3.1 on Windows 7 Prof. 32 Bit.
Here we have a virtual repository with 99 real repositories inside:
http://najut.org/~blackarchon/virtual_repo.jpg

If i double click on a directory with special characters like ä, ö, ü, ß or µ, I get such error messages:
http://najut.org/~blackarchon/error1.jpg
http://najut.org/~blackarchon/error2.jpg

But if I open the directory directly without opening the virtual repository first, there are no problems. I can open the branch and commit changes without any issues.

So what can be done to fix this error?

[Martin Packman (gz)]

I can reproduce this with trunk qbzr and explorer. Setting BZR_PDB lets you see a traceback along the lines of:

  ...\bzrlib\plugins\explorer\lib\commands.py(164)run()
-> app.exec_()
  ...\bzrlib\plugins\explorer\lib\view_repository.py(247)do_double_clicked()
-> self.do_open_location()
  ...\bzrlib\plugins\explorer\lib\view_repository.py(189)do_open_location()
-> abspath = self._get_abspath(self._relpath)
  ...\bzrlib\plugins\explorer\lib\view_repository.py(243)_get_abspath()
-> return self._get_root_transport().abspath(relpath)
  ...\bzrlib\transport\local.py(110)abspath()
-> path = osutils.normpath(osutils.pathjoin(
> ...\bzrlib\urlutils.py(536)unescape()
-> raise errors.InvalidURL(url, 'URL was not a plain ASCII url: %s' % (e,))

So it seems bzr-explorer is violating a bzrlib expectation about how urls should be formed. I think there must be a bug in the qbzr error handling as well as the traceback doesn't end up in .bzr.log for some reason.