Reviews sorting should use upstream version
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
software-center (Ubuntu) |
Fix Released
|
Low
|
Gary Lasker | ||
Natty |
Fix Released
|
Low
|
Unassigned |
Bug Description
Binary package hint: software-center
Software Center version 4.0.1
We currently sort reviews in Software Center's details view based on upstream version number of the package, followed by "usefulness" of the review as voted by users, and lastly by date of the review. With the version comparison, reviews for previous upstream versions are pushed later in the list and are tagged with the line "This review was written for a previous version of <packagename> (Version: <upstream version number>)".
For some packages, however, the sorting by usefulness for a given upstream package version is incorrect. For an example of this, see the attached screenshot that shows the list of reviews for the Inkscape package and note that the review by "dreamsare4living" with a usefulness of "3 out of 3" is incorrectly located *above* the review by "Erik B. Anderson" with a usefulness of "4 out of 4". Instead, the reviews should be sorted from highest usefulness to lowest for any given upstream version.
TEST CASE:
1. Open Software Center version 4.0.1.
2. Navigate to the Inkscape package details view.
3. Examine the list of reviews and note that the initial set of reviews for the current version of Inkscape are not correctly sorted by usefulness rating, current reviews as shown:
8 of 8 people...
4 of 4 people...
3 of 3 people...
4 of 4 people... <-- this review is out of order
3 of 5 people...
4. Close Software Center and install version 4.0.2 from natty-proposed.
5. Open Software Center version 4.0.2 and navigate back to Inkscape.
6. Verify that the reviews are now sorted correctly by usefulness, as shown for current reviews:
8 of 8 people...
4 of 4 people...
4 of 4 people...
3 of 3 people...
3 of 5 people...
Changed in software-center (Ubuntu): | |
status: | Triaged → In Progress |
Changed in software-center (Ubuntu Natty): | |
status: | New → In Progress |
importance: | Undecided → Low |
description: | updated |
tags: | added: testcase |
This bug was fixed in the package software-center - 4.1.1
---------------
software-center (4.1.1) oneiric; urgency=low
[ Gary Lasker ] utils.py, test_unity_ launcher_ integration. py: db/reviews. py, test_reviews. py:
* softwarecenter/
test/
- fix intermittent crash when installing a local .deb,
add corresponding test case (LP: #768158)
* softwarecenter/
test/
- sort reviews using upstream package versions to fix
incorrect sort by usefulness, update unit test
(LP: #777583)
[ Aaron Peachey ] software- center, utils/update- software- center- agent software- center (LP #728896) useful_ votes_helper. py to the setup scripts
* utils/update-
- fix 'no log handler' error on update-
* lp:~aaronp/software-center/enhance-usefulness:
- load/cache users usefulnes votes
* add utils/get_
[ Michael Vogt ] reviews_ helper. py:
* merged lp:~weblive-dev/software-center/weblive-set-locale, many
thanks
* support pagination ("Show more reviews" button) when there are
more reviews than fitting in a returned "page"
* utils/get_
- if there are no reviews for the current distroseries, fallback
to the previous one (LP: #783331)
* updated tests for oneiric
-- Michael Vogt <email address hidden> Mon, 16 May 2011 09:53:04 +0200