Errors with insmod, modprobe, modinfo

[Peter Wu]

Binary package hint: bash-completion

insmod, modprobe and modinfo are handled by one function: _insmod. There is a problem with this approach: the programs are completely different.

insmod does not accept options like -x and --xxx, only modules or paths to modules.

modprobe accepts several -x and --xxx options, these can not always be combined.

modinfo acepts paths to modules or module names, the kernel version can be specified

The following cases generate errors / unexpected behavior:
$ insmod x x<tab>
ERROR: modinfo: could not find module x
$ modinfo x x<tab>
ERROR: modinfo: could not find module x
$ modprobe x x<tab>
ERROR: modinfo: could not find module x
$ modinfo -k 2.6.35-28-generic x<tab>
/sbin/modinfo: option requires an argument -- 'k'
Usage: /sbin/modinfo [-0][-F field][-k kernelversion][-b basedir] module...
 Prints out the information about one or more module(s).
 If a fieldname is given, just print out that field (or nothing if not found).
 Otherwise, print all information out in a readable form
 If -0 is given, separate with nul, not newline.
 If -b is given, use an image of the module tree.

The proposed patch fixes these issues (partially):
- insmod: completely fixed
- modprobe: arguments are incomplete (todo)
- modinfo: completely fixed

The patch can be added to the debian/patches/ directory directly after a review.

[Daniel Black (daniel-black)]

added upstream: https://alioth.debian.org/tracker/index.php?func=detail&aid=313498&group_id=100114&atid=413095

[Daniel Black (daniel-black)]

fixed upstream: http://anonscm.debian.org/gitweb/?p=bash-completion/bash-completion.git;a=commit;h=f67818e023f9afbeef8698fdd3c08eb0f90ad468