"Update service from song edit" does work "too much"
Bug #772523 reported by
Andreas Preikschat
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenLP |
Fix Released
|
Low
|
Tim Bentley |
Bug Description
Hello,
xubuntu 10.10 trunk 1495
The setting "Update service from song edit" is disabled.
1) Add a song to the service
2.1) Edit the song in the Media Manager
Result:
Song in the Service Manger will be updated.
1) Add a song to the service
2.2) Edit the song in the Service Manager
Result:
Song in the Media Manager will be updated.
Expected result:
The song(s) should not be updated (neither in the Service Manager nor in the Media Manager).
Related branches
lp:~trb143/openlp/bug-772523
- Raoul Snyman: Approve
- Andreas Preikschat: Pending requested
-
Diff: 349 lines (+91/-21)11 files modifiedopenlp/core/lib/db.py (+8/-1)
openlp/core/lib/eventreceiver.py (+4/-0)
openlp/core/lib/serviceitem.py (+2/-0)
openlp/core/ui/maindisplay.py (+2/-2)
openlp/core/ui/servicemanager.py (+25/-6)
openlp/plugins/songs/forms/songexportform.py (+3/-0)
openlp/plugins/songs/lib/db.py (+2/-1)
openlp/plugins/songs/lib/mediaitem.py (+15/-3)
openlp/plugins/songs/lib/upgrade.py (+12/-1)
openlp/plugins/songs/lib/xml.py (+6/-7)
openlp/plugins/songs/songsplugin.py (+12/-0)
Changed in openlp: | |
importance: | Undecided → Low |
Changed in openlp: | |
milestone: | 1.9.6 → 1.9.7 |
Changed in openlp: | |
assignee: | nobody → Tim Bentley (trb143) |
Changed in openlp: | |
status: | Confirmed → In Progress |
Changed in openlp: | |
status: | In Progress → Fix Committed |
Changed in openlp: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Note, editing media item song didn't seem to update service song immediately. Going live on that song still showed the unedited version. However when I edited the song, it then showed the media manager version, not the service version