Closed images are not removed from the Window menu on OS X

[gradha]

After playing with the software and noticing bugs #772193 and #772195, I did close all the opened files with Command+W and got a blank screen. Opening at this point the "Window" menu to see the opened files showed a stale list. Attaching screenshot.

[Cameron White (cameronwhite91)]

Can you still reproduce this with the Pinta 1.2 alpha build? (https://github.com/downloads/PintaProject/Pinta/Pinta-1.2-alpha.app.zip)

[grofaty (grofaty)]

Can someone test this bug please if it reappears in Pinta for OSX? Pinta v1.3 was released today with huge amount of Pinta for OSX fixes. So it is likely this bug is fixed. Please test. Download it from: http://www.pinta-project.com/download.ashx

[gradha (gradha)]

The bug remains, an easier shorter path to test is:

1. Open Pinta.
2. Pinta opens with a default named unsaved image.
3. Close the image with Cmd+W. Pinta shows no white canvas and removes the unsaved image title.
4. Open the "Window" menu and there it is, the unsaved image with a checkbox, where none should appear.

[Cameron White (cameronwhite91)]

Does anything bad happen if you click on one of the entries?

[gradha (gradha)]

Nothing seems to happen. At some point trying to open/close files the program crashed, but I can't reproduce it. Still here's the crashlog in case it helps. Here's the text version (looks like osx keeps binary crashlogs?):

Process: mono [13423]
Path: /Library/Frameworks/Mono.framework/Versions/Current/bin/mono
Identifier: com.ximian.pinta
Version: 1.3 (1.3)
Code Type: X86 (Native)
Parent Process: launchd [297]

Date/Time: 2012-05-01 23:31:29.841 +0200
OS Version: Mac OS X 10.6.8 (10K549)
Report Version: 6

Exception Type: EXC_BAD_ACCESS (SIGABRT)
Exception Codes: KERN_INVALID_ADDRESS at 0x0000000063614d20
Crashed Thread: 0 Dispatch queue: com.apple.main-thread

Application Specific Information:
abort() called

Thread 0 Crashed: Dispatch queue: com.apple.main-thread
0 libSystem.B.dylib 0x90064c5a __kill + 10
1 libSystem.B.dylib 0x90064c4c kill$UNIX2003 + 32
2 libSystem.B.dylib 0x900f75a5 raise + 26
3 libSystem.B.dylib 0x9010d6e4 abort + 93
4 mono 0x000b9b64 mono_handle_native_sigsegv + 1060 (mini-exceptions.c:2246)
5 mono 0x000048fe mono_sigsegv_signal_handler + 334 (mini.c:5890)
6 libSystem.B.dylib 0x9006a05b _sigtramp + 43
7 ??? 0xffffffff 0 + 4294967295
8 com.apple.AppKit 0x941dbdd6 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 156
9 libgdk-quartz-2.0.0.dylib 0x028259ba poll_func + 282
10 libglib-2.0.0.dylib 0x02e5be9f g_main_context_poll + 280
11 libglib-2.0.0.dylib 0x02e5b1aa g_main_context_iterate + 1183
12 libglib-2.0.0.dylib 0x02e5ba2a g_main_loop_run + 992
13 libgtk-quartz-2.0.0.dylib 0x0231485b gtk_main + 239 (gtkmain.c:1257)
14 ??? 0x1908d07c 0 + 420008060
15 ??? 0x1908d044 0 + 420008004
16 ??? 0x004ed10c 0 + 5165324
17 ??? 0x004ed297 0 + 5165719
18 mono 0x00010624 mono_jit_runtime_invoke + 164 (mini.c:5764)
19 mono 0x001c1032 mono_runtime_invoke + 137 (object.c:2755)
20 mono 0x001c3940 mono_runtime_exec_main + 669 (object.c:3939)
21 mono 0x001c2c7a mono_runtime_run_main + 843 (object.c:3561)
22 mono 0x0008943d mono_main + 7773 (driver.c:1856)
23 mono 0x00002db5 start + 53

Thread 1:
0 libSystem.B.dylib 0x90003afa mach_msg_trap + 10
1 libSystem.B.dylib 0x90004267 mach_msg + 68
2 mono 0x0010a8b4 mach_exception_thread + 180 (mini-darwin.c:137)
3 mono 0x0026f8bb GC_start_routine + 107 (pthread_support.c:1468)
4 libSystem.B.dylib 0x90031259 _pthread_start + 345
5 libSystem.B.dylib 0x900310de thread_start + 34

Thread 2:
0 libSystem.B.dylib 0x90003b36 semaphore_wait_trap + 10
1 mono 0x0024b6a6 mono_sem_wait + 36 (mon...

[Cameron White (cameronwhite91)]

Hopefully this change will fix the issue: https://github.com/PintaProject/Pinta/commit/37d30cf127c542bcf5808c7f68b590f435435c72

I'll put out a new development preview soon so that this fix can be verified.

[Cameron White (cameronwhite91)]

Can you verify this fix with https://github.com/downloads/PintaProject/Pinta/Pinta-1.5-preview-20121118.app.zip ?

[Cameron White (cameronwhite91)]

I've heard from a Mac user that this is fixed with the latest development preview, so this issue can stay as Fix Committed.