fix 8VSB & 16VSB channel xine dump for ATSC channel scan

[Michael Krufky]

Binary package hint: w-scan

SRU impact statement / TEST CASE:
Xine formatted output from w_scan is incorrect for 8VSB and 16VSB modulations. The output should read "8VSB" and "16VSB" rather than "VSB_8" and "VSB_16"

Unfortunately, from what I can tell, this applies to w-scan in *every* version of Ubuntu -- the last non-broken upstream w_scan release was 20081106 -- the bug was present in all releases thereafter.

Patch / Resolution:
Michael's patch has been accepted and is currently in Oneiric's version.

Patches for lucid-proposed (https://bugs.launchpad.net/ubuntu/+source/w-scan/+bug/771786/+attachment/2219549/+files/w-scan_20091230-1ubuntu0.1.debdiff), maverick-proposed (https://bugs.launchpad.net/ubuntu/+source/w-scan/+bug/771786/+attachment/2219550/+files/w-scan_20100316-3ubuntu0.1.debdiff), and natty-proposed (https://bugs.launchpad.net/ubuntu/+source/w-scan/+bug/771786/+attachment/2219551/+files/w-scan_20101001-1ubuntu0.1.debdiff) are attached.

Regression risk:
Slim to none. No code paths are altered by this patch.

Additional information from original description:
Side note: The program is actually called w_scan with an underscore (_). The author makes note of this explicitly in his changelog: "ChangeLog:28: - NOTE@maintainers: it's called 'w_scan', not 'w-scan' or 'wscan'."

I've attached a patch that solves this bug. The patch has already been sent upstream, and shall be included in the next release of w_scan.

[Daniel T Chen (crimsun)]

Oneiric has 20110616-1, which contains the fix. Marking Oneiric as fixed.

[Chris Halse Rogers (raof)]

SRU team ack for lucid- and maverick-proposed packages.

The natty-proposed package is a 3.0 (quilt) package, and the changes have been applied as an autogenerated debian-changes patch. Although it's largely a stylistic matter I'd prefer to have a proper patch header and patch name.

I'm still calibrating my SRU-accept-meter, so if other members of the SRU team disagree with this I'm happy for natty-proposed to go through too.

[Martin Pitt (pitti)]

Hello Michael, or anyone else affected,

Accepted w-scan into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Martin Pitt (pitti)]

Hello Michael, or anyone else affected,

Accepted w-scan into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Martin Pitt (pitti)]

I agree; the maverick update has a proper patch name; for the natty one you'd just need to rename the patch and update the patch header accordingly.

[Clint Byrum (clint-fewbar)]

For the record I think the patch name and description are still a little weak (The description should be of the actual change the patch makes). However, the bug reference is correct and the patch is extremely straight forward, so I'll accept it.

[Clint Byrum (clint-fewbar)]

Hello Michael, or anyone else affected,

Accepted w-scan into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Daniel T Chen (crimsun)]

Thanks, Clint. Since the natty-proposed source FTBFS (ugh) because of a header change, I'll go ahead and fix up the patch name and description as well for the next upload.

[Daniel T Chen (crimsun)]

I've addressed Clint's concerns in a reworked SRU proposal and uploaded to natty-proposed; see bug 815500 for the FTBFS fix.

[Clint Byrum (clint-fewbar)]

Hello Michael, or anyone else affected,

Accepted w-scan into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Brian Murray (brian-murray)]

The fix for this bug has been awaiting testing feedback in the -proposed repository for lucid for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

[Brian Murray (brian-murray)]

The version of w-scan in lucid-proposed has been removed as this bug report was not verified in a timely fashion.

[Rolf Leggewie (r0lf)]

lucid has seen the end of its life and is no longer receiving any updates. Marking the lucid task for this ticket as "Won't Fix".