Exception when comparing tasks

[Javier Collado]

Using the latest code (rev. 387), the following exception is raised when tasks are compared:

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/doit/doit_cmd.py", line 478, in cmd_main
    return sub_cmd['run'](cmd_args, sub=sub_cmd)
  File "/usr/lib/python2.7/dist-packages/doit/cmdparse.py", line 229, in __call__
    return self.do_cmd(params, args)
  File "/usr/lib/python2.7/dist-packages/doit/doit_cmd.py", line 185, in cmd_run
    params['num_process'])
  File "/usr/lib/python2.7/dist-packages/doit/cmds.py", line 26, in doit_run
    task_control = TaskControl(task_list)
  File "/usr/lib/python2.7/dist-packages/doit/control.py", line 115, in __init__
    self.targets[dep] not in task.task_dep):
  File "/usr/lib/python2.7/dist-packages/doit/task.py", line 361, in __eq__
    return self.name == other.name
AttributeError: 'str' object has no attribute 'name'

Apparently, task dependencies are strings, but the Task.__eq__ comparison method expects them to be only Task objects.

[Javier Collado (javier.collado)]

The attached patch fixes the issue and doesn't break any test.

However, I'm not sure if comparing a Task against a string is fine with doit design.

[Javier Collado (javier.collado)]

Attaching the same patch with the color escape sequences removed

[schettino72 (schettino72)]

it should no go to task.__eq__ ... just get the name of the task.

can you try this:

=== modified file 'doit/control.py'
--- doit/control.py 2011-04-16 17:26:58 +0000
+++ doit/control.py 2011-04-25 08:32:55 +0000
@@ -112,7 +112,7 @@
         for task in self.tasks.itervalues():
             for dep in task.file_dep:
                 if (dep in self.targets and
- self.targets[dep] not in task.task_dep):
+ self.targets[dep].name not in task.task_dep):
                     task.task_dep.append(self.targets[dep].name)