Question.get*Recipients could be cached
Bug #769160 reported by
Curtis Hovey
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Curtis Hovey |
Bug Description
There are several bugs tracking timeouts caused by sending emails. While we want to send emails out of proc, there is an immediate benefit to reducing the cost of repetitive queries building the recipients. All the call sites of the recipient methods are working with static data; is cannot change once the set is built. All the callsites use this data after the subscriber set could have changed. Changing the methods to cached properties will benefit BugTask:
Related branches
lp:~sinzui/launchpad/question-recipients-0
- Benji York (community): Approve (code)
-
Diff: 377 lines (+52/-80)7 files modifiedlib/lp/answers/browser/tests/views.txt (+0/-21)
lib/lp/answers/configure.zcml (+1/-1)
lib/lp/answers/doc/notifications.txt (+12/-23)
lib/lp/answers/doc/question.txt (+14/-10)
lib/lp/answers/interfaces/question.py (+7/-16)
lib/lp/answers/model/question.py (+16/-7)
lib/lp/answers/notification.py (+2/-2)
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r12918 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 12918>.