Add Adblock toggle to statusbar

[Cris Dywan]

When using Adblock it can be useful to temporarily turn it off when experiencing problems on a site. Since extensions are inside the Preferences dialogue now it is more cumbersome to do so.

There should be a button created by Adblock that sits in the statusbar. There is some code creating an image already, which was never finished, it can be replaced with a GtkTogglebutton, maybe an error icon for the icon, and add a boolean setting to the extension that is checked in the callback that blocks sites.

[natano (natanoptacek)]

The patch implements a toggle button for adblock (can be enabled/disabled per tab). The patch still needs some work, but it would be nice to get some preliminary feedback, especially if a per tab toggle is wanted.

[Cris Dywan (kalikiana)]

This probably needs a custom icon - we could ask Dan to make one. An idea might be to share the icon/ button style code but I wouldn't insist on it. Looks sensible in general. I'm subscribing Alex on the bug.

[natano (natanoptacek)]

Yes, a custom button would be really nice.
I think sharing the button style code is a good idea.

[Liviu Andronic (landronimirc)]

Isn't this a duplicate of Bug #715235 ?

[1] https://bugs.launchpad.net/midori/+bug/715235

[natano (natanoptacek)]

#715235 seems to be a superset of this ticket

[Danielle Foré (danrabbit)]

symbolic adblock icon :)

[natano (natanoptacek)]

Attached are some updated patches. They should apply in order.
Any opinions?

[Luca Theidig (alsternerd)]

It would be a bit more beautiful if you don't put it into the statusbar but in the navigation or menuebar so that the statusbar is not needed at small screens.

A second thing is to enable extensions in private mode to use adblock in private too.
adblock is such a gift to privacy.

[Cody Garver (codygarver)]

I am unable to apply this patch using either patch -p0 or patch -p1. What am I missing?

[Cody Garver (codygarver)]

git apply also failed me.

git apply ~/Downloads/midori-768568-adblock-toggle-button.patch
error: patch failed: extensions/adblock.c:434
error: extensions/adblock.c: patch does not apply

[Zlip (zlip-792)]

Comment 7: https://bugs.launchpad.net/midori/+bug/768568/comments/7
This icon is too close looking as Mixed Content blocking icon of other browsers, it should be more like Caution symbolic icon which is already used by many other similar functionality addons in other browsers. Hope you people welcome feedback on user experience as well.

[Donte Greene (flykidd)]

Has anyone found a good icon for the button yet, i would really love this feature.

[InAndOutLand (inandoutland)]

What do I do with this patch file?