function tagList($name, $object, $target = null) broken

Bug #767248 reported by TitanKing
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
PHPDevShell
Fix Released
High
Greg

Bug Description

Their seems to be a broken method in
function tagList($name, $object, $target = null)

If I pass only values $this->tagList(null, 'role', 13); the returned value is always empty.

I do however expect the problem lies in the queryclass, where this is not correctly assembled:
  if (!empty($object)) $this->addWhere("tagObject = '%s'");
  if (!empty($name)) $this->addWhere("tagName = '%s'");
  if (!empty($target)) $this->addWhere("tagTarget = '%s'");

  return parent::extraBuild($parameters);

Revision history for this message
TitanKing (titan-phpdevshell) wrote :

Note, I made sure tag does exist in database.

Revision history for this message
Greg (gregfr) wrote :

OK I found the bug, I'll fix it.

Revision history for this message
TitanKing (titan-phpdevshell) wrote :

Was this fixed and pushed already?

Revision history for this message
Greg (gregfr) wrote :

I think it should be fixed now

Changed in phpdevshell:
status: New → Fix Committed
Changed in phpdevshell:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.