Unable to log in to RabbitMQ 2.4.1

[Philip K. Warren]

This is a continuation of problems which are still persisting when connecting to RabbitMQ 2.4 after the fix for Bug 741147. The new error is due to failing to parse a boolean value in the table (there are four boolean values - publisher_confirms, exchange_exchange_bindings, basic.nack, and consumer_cancel_notify).

To resolve the issue, I propose the following fix to codec.py:

=== modified file 'src/txamqp/codec.py'
--- src/txamqp/codec.py 2011-04-04 14:41:10 +0000
+++ src/txamqp/codec.py 2011-04-07 21:26:20 +0000
@@ -189,6 +189,8 @@
         value = self.decode_long()
       elif type == "F":
         value = self.decode_table()
+ elif type == "t":
+ value = (self.decode_octet() != 0)
       else:
         raise ValueError(repr(type))
       result[key] = value

[Thomas Herve (therve)]

It would be nice to add a decode_bool procedure instead. It would also be nice to have a test case.

[Maarten Damen (m-damen)]

I tried this patch using both the 0.9 and 0.9.1 spec but it didn't work for me. I get the following traceback:
[Failure instance: Traceback (failure with no frames): <class 'twisted.internet.error.ConnectionDone'>: Connection was closed cleanly.]

0.8 spec still works fine. Any thoughts?