pyflakes complains about missing WindowsError on Unix
Bug #764627 reported by
Adi Roiban
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Pyflakes |
Fix Released
|
Low
|
Unassigned | ||
| pocket-lint |
Fix Released
|
Low
|
Adi Roiban | ||
Bug Description
Since pyflakes website is down I am reporting this bug in LP.
The undefined name WindowsError is raised by pyflakes when running on Unix systems.
It would be nice if pyflakes would trust the developer that such code is only loaded on Windows and allow to check Windows specific Python code on Unix.
----
Please let me know if you thinks it is a valid problem.
Also any advice about how to move this bug report upstream is much appreciated.
----
I have also attached a pocket-lint branch that works around this problem.
Cheers,
Related branches
lp:~adiroiban/pocket-lint/pocket-lint-764627
- Curtis Hovey: Approve (code)
-
Diff: 95 lines (+35/-4)2 files modifiedpocketlint/formatcheck.py (+17/-4)
pocketlint/tests/test_python.py (+18/-0)
lp:~divmod-dev/divmod.org/windowserror-builtin
- Tristan Seligmann: Approve
- Jonathan Jacobs: Approve
-
Diff: 34 lines (+11/-2)2 files modifiedPyflakes/pyflakes/checker.py (+3/-2)
Pyflakes/pyflakes/test/test_undefined_names.py (+8/-0)
| description: | updated |
| description: | updated |
| Changed in pocket-lint: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
Revision history for this message
| Adi Roiban (adiroiban) wrote | #1 |
| Changed in pocket-lint: | |
| milestone: | none → 0.5.15 |
| status: | Triaged → Fix Committed |
| milestone: | 0.5.15 → none |
| milestone: | none → 0.5.15 |
| Changed in pocket-lint: | |
| assignee: | nobody → Adi Roiban (adiroiban) |
| status: | Fix Committed → Fix Released |
| Changed in pyflakes: | |
| status: | New → Fix Committed |
| Changed in pyflakes: | |
| importance: | Undecided → Low |
| milestone: | none → 0.6.1 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hi Curtis,
Do you have any suggestion about how this bug should be solved?
Do you want to have it fixed in pocket-lint or in pyflakes?
What do you say about the changes from the attached branch?
Cheers,
Adi