Parameter mismatch when calling _create_image() from spawn() in libvirt_conn.py
Bug #764236 reported by
Yoshiaki Tamura
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Undecided
|
Yoshiaki Tamura |
Bug Description
The definition of _create_image() in nova/virt/
def _create_image(self, inst, libvirt_xml, suffix='', disk_images=None, network_info=None):
However in spawn(), it's passing network_info to suffix:
def spawn(self, instance, network_info=None):
...
self.
It should be fixed to:
self._create_
Related branches
lp:~tamura-yoshiaki/nova/bug-764236
- Vish Ishaya (community): Approve
- Devin Carlen (community): Approve
- termie (community): Approve
-
Diff: 60 lines (+38/-1)2 files modifiednova/tests/test_virt.py (+37/-0)
nova/virt/libvirt_conn.py (+1/-1)
Changed in nova: | |
assignee: | nobody → Yoshiaki Tamura (tamura-yoshiaki) |
status: | New → In Progress |
Changed in nova: | |
status: | In Progress → Fix Committed |
Changed in nova: | |
milestone: | none → diablo-1 |
Changed in nova: | |
milestone: | diablo-1 → 2011.3 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I've updated my branch that first introduces a test which checks spawn() with network_info specified, and followed by the fix.