qBittorrent crashes when adding RSS rules

Bug #762208 reported by Fabien V
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qBittorrent
Fix Released
High
Christophe Dumez

Bug Description

Immediately after naming a new download rule, qBittorrent crashes every time.

Hi, this bug has been reported in the Chakra forums.
Please see this thread http://chakra-project.org/bbs/viewtopic.php?id=4529
But basically, bug reported with latest libtorrent-raster and latest qbittorrent 2.7.2.
See especially the post 12 and 13 for backtraces.
It crashes with "ASSERT: "m_rules.contains(name)" in file rss/rssdownloadrulelist.cpp, line 177
"

I had a quick look at the code and actually in rss/automatedrssdownloader.cpp line 286, when a new rule is created it calls rssdownloadrulelist::getrule().
this rule doesn't exist yet and thus the Q_ASSERT (rss/rssdownloadrulelist.cpp line 177) is closing the soft for new rules.
At least that is what I think, I might be wrong...

Revision history for this message
Christophe Dumez (hydr0g3n) wrote :

I'll have a look and fix it for v2.7.3 (to be released this week end). Thanks.

Changed in qbittorrent:
assignee: nobody → Christophe Dumez (hydr0g3n)
importance: Undecided → High
milestone: none → 2.7.3
status: New → Confirmed
Revision history for this message
Christophe Dumez (hydr0g3n) wrote :

According to my findings, the ASSERT that is hit simply should not be there. I merely removed it to fix the problem.

However, this means that it would only crash in debug mode (./configure --enable-debug). Are all these people on the forum using qBittorrent in debug mode? Why would they?

Changed in qbittorrent:
status: Confirmed → Fix Committed
Revision history for this message
Fabien V (hcooh) wrote :

Thank you for your quick reactivity !
Concerning the debug mode, actually, we are not enabling it...
This is part of the code used to make the package :

source=(http://downloads.sourceforge.net/sourceforge/qbittorrent/${pkgname}-${pkgver}.tar.gz)
md5sums=('0ebd9ff8a0963b5cc7092f328d6df105')

build()
{
    cd ${srcdir}/${pkgname}-${pkgver}
    ./configure --prefix=/usr
    make
}

package()
{
    cd ${srcdir}/${pkgname}-${pkgver}
    make INSTALL_ROOT=${pkgdir} install
}

So I don't really know why debug is enabled... (but I'm a new packager...)

Revision history for this message
Christophe Dumez (hydr0g3n) wrote :

Yes, I double-checked your package also and it is correct. This is my bad, assertions were actually enabled by default in release mode due to a bug in my configure file. This is also fixed in v2.7.3 and should improve performance quite a bit :)

Thanks a lot for the bug report and please package v2.7.3 :)
Please do not hesitate to file bug reports again.

Changed in qbittorrent:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.