Mailin daemon leaves orphan database connections when there is an error

[Chris Rossi]

In the staging environment on gocept it has been observed that if the mailin daemon encounters an error that raises an exception, it does not properly clean up the database connection to the *karl* database (not necessarily the postoffice database, although in this case the error was that it couldn't connect to the postoffice database so its possible that connection could get left behind too, if it were created). This was observable as a growing number of postgresql worker processes on the database server. More than likely the path for exception handling in daemons needs to be examined with an eye on making sure database connections are cleaned up even when exceptions are raised.

[Paul Everitt (paul-agendaless)]

Any chance at all that this could be related to memory problems in production?

--Paul

On Apr 15, 2011, at 9:47 AM, Chris Rossi wrote:

> Public bug reported:
>
> In the staging environment on gocept it has been observed that if the
> mailin daemon encounters an error that raises an exception, it does not
> properly clean up the database connection to the *karl* database (not
> necessarily the postoffice database, although in this case the error was
> that it couldn't connect to the postoffice database so its possible that
> connection could get left behind too, if it were created). This was
> observable as a growing number of postgresql worker processes on the
> database server. More than likely the path for exception handling in
> daemons needs to be examined with an eye on making sure database
> connections are cleaned up even when exceptions are raised.
>
> ** Affects: karl3
> Importance: Undecided
> Status: New
>
> --
> You received this bug notification because you are subscribed to KARL3.
> https://bugs.launchpad.net/bugs/761778
>
> Title:
> Mailin daemon leaves orphan database connections when there is an
> error
>
> Status in KARL3:
> New
>
> Bug description:
> In the staging environment on gocept it has been observed that if the
> mailin daemon encounters an error that raises an exception, it does
> not properly clean up the database connection to the *karl* database
> (not necessarily the postoffice database, although in this case the
> error was that it couldn't connect to the postoffice database so its
> possible that connection could get left behind too, if it were
> created). This was observable as a growing number of postgresql
> worker processes on the database server. More than likely the path
> for exception handling in daemons needs to be examined with an eye on
> making sure database connections are cleaned up even when exceptions
> are raised.

[Chris Rossi (chris-archimedeanco)]

On Fri, Apr 15, 2011 at 10:06 AM, Paul Everitt <email address hidden> wrote:

> Any chance at all that this could be related to memory problems in
> production?
>

Not really.

[Paul Everitt (paul-agendaless)]

Actually I can move this out of the way, as it is RelStorage related. I'll put this in the "should be done in May" milestone.