Several modules use "!= None" instead of "is not None"

Bug #759108 reported by Jason Kölker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Jason Kölker

Bug Description

$ grep -R "!= None" *
nova/auth/dbdriver.py: if member_uids != None:
nova/api/ec2/apirequest.py: elif data != None:
nova/virt/libvirt_conn.py: if ctx != None:
nova/virt/libvirt_conn.py: if doc != None:
nova/virt/libvirt_conn.py: if ctx != None:
nova/virt/libvirt_conn.py: if doc != None:
nova/virt/libvirt_conn.py: if ctx != None:
nova/virt/libvirt_conn.py: if doc != None:
nova/compute/monitor.py: if data != None:
nova/tests/api/openstack/test_servers.py: if host != None:
nova/db/sqlalchemy/api.py: filter(models.FixedIp.instance_id != None).\
nova/db/sqlalchemy/api.py: filter(models.FixedIp.instance_id != None).\
nova/db/sqlalchemy/api.py: return group != None
nova/utils.py: if process_input != None:
tools/esx/guest_tool.py: if process_input != None:

Related branches

Revision history for this message
Jason Kölker (jason-koelker) wrote :

These are correct per http://www.sqlalchemy.org/docs/orm/tutorial.html#common-filter-operators

nova/db/sqlalchemy/api.py: filter(models.FixedIp.instance_id != None).\
nova/db/sqlalchemy/api.py: filter(models.FixedIp.instance_id != None).\

Changed in nova:
assignee: nobody → Jason Kölker (jason-koelker)
Changed in nova:
status: New → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → diablo-1
Thierry Carrez (ttx)
Changed in nova:
milestone: diablo-1 → 2011.3
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.