stale notification after an AJAX action

[Diogo Matsubara]

1. Open https://translations.qastaging.launchpad.net/ubuntu/natty/+source/gnuhello/+sharing-details
2. Make sure there's a linked upstream series (e.g. Gwibber 1.0 series)
3. Unlink the upstream series, you'll see a message: "Removed upstream association between Gwibber 1.0 series and Natty."
4. Add the upstream link again using the AJAX overlay
5. The message displayed on step 3 is still there.

This was found in the translations sharing details page but it's part of a deeper fix than just translations, perhaps in general we should get rid of notifications after AJAX actions, since they are no longer relevant

[Ian Booth (wallyworld)]

The solution for this requires some thought. I recently had implemented functionality to do what is suggested - remove notifications after AJAX actions - and this had unintended bad consequences. See bug 754058.

One possible solution - tag each AJAX request with a header item which is sent back with the response, indicating that notifications are to be reset. That way AJAX requests in general (ie non user initiated ones which are done as part of a page load) will not reset the notifications but ones we choose to will.

[Robert Collins (lifeless)]

Alternatively, and this is done on other sites very nicely, just have
a [x] button on the notifications.

Let the user clear the notification, and don't stress about
conflicting notes still being shown.

[Jonathan Lange (jml)]

This ought to be fixed before we consider the feature done, but time constraints mean making it a nice-to-have.

I think that this specific bug could be solved by fixing bug 759606, making the "remove upstream link" action an AJAX one rather than a traditional web form.