poppy-sftp's signature checking relies on long-term survival of a directory in /tmp

[William Grant]

GPGHandler keeps its GNUPGHOME and gpg.conf in /tmp/gpg-*. This is normally fine, since long-running daemons don't tend to use GPGHandler.

But poppy-sftp does. Once its gpg.conf is old enough, a /tmp pruner will delete it and it will no longer be able to retrieve keys.

[Robert Collins (lifeless)]

sinzui said on the dupe:

Sinzui: Does the fix for this entail preventing reaping or automatic recreation?

lifeless: long term is a code change to either stop using one long gpghandler or put it somewhere else. The problem isn't that its in /tmp, its that its written at daemon startup and untouched for 5 days or 4 days or whatever the reaper config is

/me ponders a hack to touch the file every 12 hours.

I do not see an issue with putting it somewhere else, but I think creating a new gpghandler every n hours is the better way to solve this.

[Ian Booth (wallyworld)]

After discussion with Curtis, we decided the best approach was to touch the config directory every 12 hours rather than creating a new handler or new config. This is the lowest risk, least invasive, most robust approach.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r12987 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12987>.

[William Grant (wgrant)]

An SFTPServer is instantiated for each authenticated SFTP session, so: A) it doesn't touch until the first SFTP user authenticates, despite it being required for FTP, and B) each new session will create the LoopingCall, and they won't be destroyed until the end.

I'm rolling this back. I'd suggest moving the scheduling into poppy-sftp.tac. Apart from that it looks OK.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r13063 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13063>.

[Martin Pool (mbp)]

see also bug 882324