lilo.conf bad bmp reference

Bug #7572 reported by Debian Bug Importer
4
Affects Status Importance Assigned to Milestone
lilo (Debian)
Fix Released
Unknown
lilo (Ubuntu)
Fix Released
Medium
Clint Adams

Bug Description

Automatically imported from Debian bug report #267538 http://bugs.debian.org/267538

Revision history for this message
In , Andrés Roldán (aroldan) wrote : Re: Bug#267538: lilo.conf bad bmp reference

severity 267538 grave
thanks

Fabrice LORRAIN <email address hidden> writes:

> My /etc/lilo.conf had the following line (wrong path):
> bitmap=/usr/share/lilo/contrib/debian.bmp

Yep, the bitmaps are not longer there.

> I didn't get any information/warning during the upgrade.
> It might be nice to check for the exit status of lilo -t during the
> installation scripts to warn the sys. admin. that something is wrong.

You're right. I'll check for wrong paths on this line and then warn
the user.

I'll set this bug to "grave" to make an upload that reach sarge
because this is a _real_ problem.

Thanks.

--
Andrés Roldán

<email address hidden> / Fluidsignal Group S.A.
<email address hidden> / The Debian Project

Mobile: +57 300-7920981
GPG F/P: 0EE9 27C9 55F1 92E4 3809 B852 D8E0 724B B293 96EB
http://people.fluidsignal.com/~aroldan

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Automatically imported from Debian bug report #267538 http://bugs.debian.org/267538

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Mon, 23 Aug 2004 10:22:38 +0200
From: Fabrice LORRAIN <email address hidden>
To: <email address hidden>
Subject: lilo.conf bad bmp reference

Package: lilo
Version: 22.5.9-6
Severity: normal

Hi,

Related to #259982.
I just upgraded a pre-sarge box installed around july.

My /etc/lilo.conf had the following line (wrong path):
bitmap=/usr/share/lilo/contrib/debian.bmp

Which render lilo unrunable :
# lilo
Fatal: open /usr/share/lilo/contrib/debian.bmp: No such file or directory

I didn't get any information/warning during the upgrade.
It might be nice to check for the exit status of lilo -t during the
installation scripts to warn the sys. admin. that something is wrong.

I ate leaving a box with a non fonctionning bootloader.

@+,

 Fab

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Mon, 23 Aug 2004 08:01:15 -0500
From: =?iso-8859-1?q?Andr=E9s_Rold=E1n?= <email address hidden>
To: Fabrice LORRAIN <email address hidden>
Cc: <email address hidden>, <email address hidden>
Subject: Re: Bug#267538: lilo.conf bad bmp reference

--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="

--=-=-=
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable

severity 267538 grave
thanks

Fabrice LORRAIN <email address hidden> writes:

> My /etc/lilo.conf had the following line (wrong path):
> bitmap=3D/usr/share/lilo/contrib/debian.bmp

Yep, the bitmaps are not longer there.

> I didn't get any information/warning during the upgrade.
> It might be nice to check for the exit status of lilo -t during the
> installation scripts to warn the sys. admin. that something is wrong.

You're right. I'll check for wrong paths on this line and then warn=20
the user.

I'll set this bug to "grave" to make an upload that reach sarge=20
because this is a _real_ problem.

Thanks.

=2D-=20
Andr=E9s Rold=E1n

<email address hidden> / Fluidsignal Group S.A.=09=09=09
<email address hidden> / The Debian Project

Mobile: +57 300-7920981
GPG F/P: 0EE9 27C9 55F1 92E4 3809 B852 D8E0 724B B293 96EB=20
http://people.fluidsignal.com/~aroldan

--=-=-=--

--==-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBKeqd2OByS7KTlusRAtSyAJ0W67byxcR80clrmetyFx4iUBvL1gCeLgHt
SYEh5edc5foTq1Deh/cqqxY=
=1aL2
-----END PGP SIGNATURE-----
--==-=-=--

Revision history for this message
Matt Zimmerman (mdz) wrote :

Not RC for Warty

Revision history for this message
Thom May (thombot) wrote :

I guess this only affects upgrades from woody, so assigning to Clint.
We can't unilaterally install grub, sadly, since there are still somethings that
it can't handle.
Probably the only sane approach is to take a similar approach to the suggested
one above and warn if the preexisting config is going to break.

Revision history for this message
In , Pierre Habouzit (madcoder) wrote : here is a patch

hi, for exercise for my T&S in the NM process, I had to solve an RC bug.

I've added a test in the lilo.config to check if a reference to that
old path was there. if yes, it uses a debconf note to warn the user,
else it does nothing.

since I'm french you even have the french translation in the patch.

the patch is against the current lilo 22.5.9-6 source package.

I'll tag the bug with the flag 'path'

cheers,
--
Pierre Habouzit http://www.madism.org/
-==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==-
gpg : 1024D/A1EE761C 6045 409E 5CB5 2CEA 3E70 F17E C41E 995C C98C 90BE
spam: <email address hidden>

Revision history for this message
In , Pierre Habouzit (madcoder) wrote : tagging 267538

# Automatically generated email from bts, devscripts version 2.8.4
tags 267538 + patch

Revision history for this message
In , Pierre Habouzit (madcoder) wrote : ... sorry

I feel stupid, I've sent the bad patch ...

this one works and has been tested.

sorry
--
Pierre Habouzit http://www.madism.org/
-==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==-
gpg : 1024D/A1EE761C 6045 409E 5CB5 2CEA 3E70 F17E C41E 995C C98C 90BE
spam: <email address hidden>

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (22.3 KiB)

Message-Id: <email address hidden>
Date: Sun, 12 Sep 2004 20:59:20 +0200
From: Pierre Habouzit <email address hidden>
To: <email address hidden>
Cc: Marc 'HE' Brockschmidt <email address hidden>
Subject: here is a patch

--nextPart4387971.XeVcXKF332
Content-Type: multipart/mixed;
  boundary="Boundary-01=_IyJRBXNQK3vJoY7"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--Boundary-01=_IyJRBXNQK3vJoY7
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

hi, for exercise for my T&S in the NM process, I had to solve an RC bug.

I've added a test in the lilo.config to check if a reference to that=20
old path was there. if yes, it uses a debconf note to warn the user,=20
else it does nothing.

since I'm french you even have the french translation in the patch.

the patch is against the current lilo 22.5.9-6 source package.

I'll tag the bug with the flag 'path'

cheers,
=2D-=20
Pierre Habouzit http://www.madism.org/
=2D=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D--=
=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D-
gpg : 1024D/A1EE761C 6045 409E 5CB5 2CEA 3E70 F17E C41E 995C C98C 90BE=20
spam: <email address hidden>

--Boundary-01=_IyJRBXNQK3vJoY7
Content-Type: text/x-diff;
  charset="iso-8859-15";
  name="lilo-bitmap.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
 filename="lilo-bitmap.patch"

diff -ru ../oldlilo/lilo-22.5.9/debian/lilo.config ./debian/lilo.config
=2D-- ../oldlilo/lilo-22.5.9/debian/lilo.config 2004-09-12 20:37:26.0000000=
00 +0200
+++ ./debian/lilo.config 2004-09-12 20:45:26.000000000 +0200
@@ -47,4 +47,9 @@
  db_go
 fi
=20
+if grep -q 'bitmap[[:space:]]*=3D[[:space:]]*/usr/share/lilo/contrib/[[:al=
pha:]]*.bmp' /etc/lilo.conf; then
+ db_text high lilo/new-config || true
+ db_go
+fi
+
 exit 0
diff -ru ../oldlilo/lilo-22.5.9/debian/lilo.templates ./debian/lilo.templat=
es
=2D-- ../oldlilo/lilo-22.5.9/debian/lilo.templates 2004-09-12 20:37:26.0000=
00000 +0200
+++ ./debian/lilo.templates 2004-09-12 20:43:56.000000000 +0200
@@ -31,3 +31,13 @@
  WARNING: This procedure will write data in your MBR and may overwrite
  some things in that place. If you skip this step, you must run /sbin/lilo
  before reboot your computer or the system may not boot again.
+
+Template: lilo/oldbmp
+Type: note
+_Description: Images have moved
+ It was detected that you have some references on images in
+ /usr/share/lilo/contrib/ in your lilo.conf.
+ .
+ those images are now in /usr/share/lilo/
+ .
+ Please edit your /etc/lilo.conf and update the path
diff -ru ../oldlilo/lilo-22.5.9/debian/po/cs.po ./debian/po/cs.po
=2D-- ../oldlilo/lilo-22.5.9/debian/po/cs.po 2004-09-12 20:37:26.000000000 =
+0200
+++ ./debian/po/cs.po 2004-09-12 20:45:53.000000000 +0200
@@ -15,7 +15,7 @@
 msgstr ""
 "Project-Id-Version: lilo\n"
 "Report-Msgid-Bugs-To: \n"
=2D"POT-Creation-Date: 2004-07-13 02:27+0000\n"
+"POT-Creation-Date: 2004-09-12 20:45+0200\n"
 "PO-Revision-Date: 2004-07-21 22:09+0200\n"
 "Last-Translator: Miroslav Kure <email address hidden>\n"
 "Langu...

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <email address hidden>
Date: Sun, 12 Sep 2004 20:59:42 +0200
From: Pierre Habouzit <email address hidden>
To: <email address hidden>
Subject: tagging 267538

# Automatically generated email from bts, devscripts version 2.8.4
tags 267538 + patch

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (22.2 KiB)

Message-Id: <email address hidden>
Date: Sun, 12 Sep 2004 21:08:30 +0200
From: Pierre Habouzit <email address hidden>
To: <email address hidden>
Cc: Marc 'HE' Brockschmidt <email address hidden>
Subject: ... sorry

--nextPart1541545.7cmK0eDp2s
Content-Type: multipart/mixed;
  boundary="Boundary-01=_u6JRBWnlwvlZp9+"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--Boundary-01=_u6JRBWnlwvlZp9+
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

I feel stupid, I've sent the bad patch ...

this one works and has been tested.

sorry
=2D-=20
Pierre Habouzit http://www.madism.org/
=2D=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D--=
=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D--=3D=3D-
gpg : 1024D/A1EE761C 6045 409E 5CB5 2CEA 3E70 F17E C41E 995C C98C 90BE=20
spam: <email address hidden>

--Boundary-01=_u6JRBWnlwvlZp9+
Content-Type: text/x-diff;
  charset="iso-8859-15";
  name="lilo-bitmap.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
 filename="lilo-bitmap.patch"

diff -ru oldlilo/lilo-22.5.9/debian/lilo.config lilo-22.5.9/debian/lilo.con=
fig
=2D-- oldlilo/lilo-22.5.9/debian/lilo.config 2004-09-12 20:37:26.000000000 =
+0200
+++ lilo-22.5.9/debian/lilo.config 2004-09-12 20:52:43.000000000 +0200
@@ -16,6 +16,9 @@
  isfresh=3D1
  db_text high lilo/new-config || true
  db_go
+elif grep -q 'bitmap[[:space:]]*=3D[[:space:]]*/usr/share/lilo/contrib/[[:=
alpha:]]*.bmp' /etc/lilo.conf; then
+ db_text high lilo/oldbmp || true
+ db_go
 fi
=20
 db_set lilo/runme =3D false
diff -ru oldlilo/lilo-22.5.9/debian/lilo.templates lilo-22.5.9/debian/lilo.=
templates
=2D-- oldlilo/lilo-22.5.9/debian/lilo.templates 2004-09-12 20:37:26.0000000=
00 +0200
+++ lilo-22.5.9/debian/lilo.templates 2004-09-12 20:43:56.000000000 +0200
@@ -31,3 +31,13 @@
  WARNING: This procedure will write data in your MBR and may overwrite
  some things in that place. If you skip this step, you must run /sbin/lilo
  before reboot your computer or the system may not boot again.
+
+Template: lilo/oldbmp
+Type: note
+_Description: Images have moved
+ It was detected that you have some references on images in
+ /usr/share/lilo/contrib/ in your lilo.conf.
+ .
+ those images are now in /usr/share/lilo/
+ .
+ Please edit your /etc/lilo.conf and update the path
diff -ru oldlilo/lilo-22.5.9/debian/po/cs.po lilo-22.5.9/debian/po/cs.po
=2D-- oldlilo/lilo-22.5.9/debian/po/cs.po 2004-09-12 20:37:26.000000000 +02=
00
+++ lilo-22.5.9/debian/po/cs.po 2004-09-12 20:45:53.000000000 +0200
@@ -15,7 +15,7 @@
 msgstr ""
 "Project-Id-Version: lilo\n"
 "Report-Msgid-Bugs-To: \n"
=2D"POT-Creation-Date: 2004-07-13 02:27+0000\n"
+"POT-Creation-Date: 2004-09-12 20:45+0200\n"
 "PO-Revision-Date: 2004-07-21 22:09+0200\n"
 "Last-Translator: Miroslav Kure <email address hidden>\n"
 "Language-Team: Czech <email address hidden>\n"
@@ -99,3 +99,29 @@
 "VAROV=C1N=CD: Tento postup zap=ED=B9e data do MBR a t=EDm p=F8ep=ED=B9e p=
=F8=EDpadn=E1 data tam "
 "um=EDst=ECn=E1. Pokud tento krok p=F8esko=E8=EDte, mus=EDte spustit /sbin=
/...

Revision history for this message
In , Andrés Roldán (aroldan) wrote : Patch for 267538

Hi Pierre.

I've already implemented a solution for this bug and
I was about to upload a new version of lilo with this
bug solved. However, I'll take some parts of your patch
to improve my solution. Hence, take your T&S point as
solved :)

Thanks.

--
Andrés Roldán

<email address hidden> / Fluidsignal Group S.A.
<email address hidden> / The Debian Project

Mobile: +57 300-7920981
GPG F/P: 0EE9 27C9 55F1 92E4 3809 B852 D8E0 724B B293 96EB
http://people.fluidsignal.com/~aroldan

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Sun, 12 Sep 2004 17:33:14 -0500
From: =?iso-8859-1?q?Andr=E9s_Rold=E1n?= <email address hidden>
To: Pierre Habouzit <email address hidden>
Cc: <email address hidden>
Subject: Patch for 267538

Hi Pierre.

I've already implemented a solution for this bug and
I was about to upload a new version of lilo with this
bug solved. However, I'll take some parts of your patch
to improve my solution. Hence, take your T&S point as
solved :)

Thanks.

--=20
Andr=E9s Rold=E1n

<email address hidden> / Fluidsignal Group S.A.
<email address hidden> / The Debian Project

Mobile: +57 300-7920981
GPG F/P: 0EE9 27C9 55F1 92E4 3809 B852 D8E0 724B B293 96EB
http://people.fluidsignal.com/~aroldan

Revision history for this message
In , Andrés Roldán (aroldan) wrote : Bug#267538: fixed in lilo 1:22.6-1
Download full text (3.4 KiB)

Source: lilo
Source-Version: 1:22.6-1

We believe that the bug you reported is fixed in the latest version of
lilo, which is due to be installed in the Debian FTP archive:

lilo-doc_22.6-1_i386.deb
  to pool/main/l/lilo/lilo-doc_22.6-1_i386.deb
lilo_22.6-1.diff.gz
  to pool/main/l/lilo/lilo_22.6-1.diff.gz
lilo_22.6-1.dsc
  to pool/main/l/lilo/lilo_22.6-1.dsc
lilo_22.6-1_i386.deb
  to pool/main/l/lilo/lilo_22.6-1_i386.deb
lilo_22.6.orig.tar.gz
  to pool/main/l/lilo/lilo_22.6.orig.tar.gz

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andrés Roldán <email address hidden> (supplier of updated lilo package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon, 13 Sep 2004 19:12:13 +0000
Source: lilo
Binary: lilo-doc lilo
Architecture: source i386
Version: 1:22.6-1
Distribution: unstable
Urgency: high
Maintainer: Andrés Roldán <email address hidden>
Changed-By: Andrés Roldán <email address hidden>
Description:
 lilo - LInux LOader - The Classic OS loader can load Linux and others
 lilo-doc - Documentation for LILO (LInux LOader)
Closes: 265812 267538 270870
Changes:
 lilo (1:22.6-1) unstable; urgency=high
 .
   * New upstream version.
   * debian/control:
     - Removed build dependency on nasm.
     - Build-Depends on dpatch (>= 2.0.0) instead of (>= 1.11)
   * debian/patches:
     - Removed the following patches. Some of them were sent to upstream and
       were incorporated into the main LILO source (see upstream's changelog):
       01_keytab-lilo-regex.dpatch, 02_lilo-2.6.dpatch, 05_lilo.8-2.dpatch,
       12_paranoia.dpatch, 11_addappend.dpatch, 12_ndevs-check.dpatch,
       03_non-root-warn.dpatch, 10_fix_check_options.dpatch.
   * debian/lilo.config:
     - Add check for invalid or deprecated path values for bitmap field on
       /etc/lilo.conf (closes: #267538)
   * Severity set to high due to the resolution of the grave bug.
   * debian/patches/03_boot-prompt.dpatch:
     - Updated menu screen's title.
   * debian/patches/03_readlink-overflow.dpatch:
     - Merged into 01_devmapper.dpatch.
   * debian/liloconfig:
     - Will add memtest86 and memtest86+ images if found.
   * debian/po:
     - Updated es.po.
     - Updated fr.po. (closes: #265812)
     - Updated da.po.
     - Updated pt_BR.po.
   * debian/patches/10_install-references.dpatch:
     - Changes confusing references to install= parameters. (closes: #270870)
Files:
 29b1a154d7eff9785e8ccabf2e88fee0 737 base optional lilo_22.6-1.dsc
 4749a41cb203d871f287c06268347497 430191 base optional lilo_22.6.orig.tar.gz
 f989f21ad975fdd1c058c5f91e675263 174615 base optional lilo_22.6-1.diff.gz
 3d807d66b70aa418999ea2445aa7926a 352342 base optional lilo_22.6-1_i386.deb
 88c6c2b23bffc39253ebf113abe64cfa 1563...

Read more...

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (3.6 KiB)

Message-Id: <email address hidden>
Date: Mon, 13 Sep 2004 15:48:30 -0400
From: =?utf-8?b?QW5kcsOpcyBSb2xkw6Fu?= <email address hidden>
To: <email address hidden>
Subject: Bug#267538: fixed in lilo 1:22.6-1

Source: lilo
Source-Version: 1:22.6-1

We believe that the bug you reported is fixed in the latest version of
lilo, which is due to be installed in the Debian FTP archive:

lilo-doc_22.6-1_i386.deb
  to pool/main/l/lilo/lilo-doc_22.6-1_i386.deb
lilo_22.6-1.diff.gz
  to pool/main/l/lilo/lilo_22.6-1.diff.gz
lilo_22.6-1.dsc
  to pool/main/l/lilo/lilo_22.6-1.dsc
lilo_22.6-1_i386.deb
  to pool/main/l/lilo/lilo_22.6-1_i386.deb
lilo_22.6.orig.tar.gz
  to pool/main/l/lilo/lilo_22.6.orig.tar.gz

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andrés Roldán <email address hidden> (supplier of updated lilo package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon, 13 Sep 2004 19:12:13 +0000
Source: lilo
Binary: lilo-doc lilo
Architecture: source i386
Version: 1:22.6-1
Distribution: unstable
Urgency: high
Maintainer: Andrés Roldán <email address hidden>
Changed-By: Andrés Roldán <email address hidden>
Description:
 lilo - LInux LOader - The Classic OS loader can load Linux and others
 lilo-doc - Documentation for LILO (LInux LOader)
Closes: 265812 267538 270870
Changes:
 lilo (1:22.6-1) unstable; urgency=high
 .
   * New upstream version.
   * debian/control:
     - Removed build dependency on nasm.
     - Build-Depends on dpatch (>= 2.0.0) instead of (>= 1.11)
   * debian/patches:
     - Removed the following patches. Some of them were sent to upstream and
       were incorporated into the main LILO source (see upstream's changelog):
       01_keytab-lilo-regex.dpatch, 02_lilo-2.6.dpatch, 05_lilo.8-2.dpatch,
       12_paranoia.dpatch, 11_addappend.dpatch, 12_ndevs-check.dpatch,
       03_non-root-warn.dpatch, 10_fix_check_options.dpatch.
   * debian/lilo.config:
     - Add check for invalid or deprecated path values for bitmap field on
       /etc/lilo.conf (closes: #267538)
   * Severity set to high due to the resolution of the grave bug.
   * debian/patches/03_boot-prompt.dpatch:
     - Updated menu screen's title.
   * debian/patches/03_readlink-overflow.dpatch:
     - Merged into 01_devmapper.dpatch.
   * debian/liloconfig:
     - Will add memtest86 and memtest86+ images if found.
   * debian/po:
     - Updated es.po.
     - Updated fr.po. (closes: #265812)
     - Updated da.po.
     - Updated pt_BR.po.
   * debian/patches/10_install-references.dpatch:
     - Changes confusing references to install= parameters. (closes: #270870)
Files:
 29b1a154d7eff9785e8ccabf2e88fee0 737 base optional lilo_22.6-1.dsc
 4749a41cb203d871f287c06268347497 430191 base...

Read more...

Revision history for this message
Matt Zimmerman (mdz) wrote :

      lilo | 1:22.6-1 | http://archive.ubuntu.com hoary/main Sources

Changed in lilo:
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.