Distroseries' parent_series attribute is misleading.
Bug #754750 reported by
Raphaël Badin
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Steve Kowalik |
Bug Description
The distroseries' parent_series attribute has been used to denote links between series as well as proper derivation relationships.
We should clean this up to properly model the child/parent relationship and probably get rid of the parent_series attribute altogether..
Related branches
lp:~julian-edwards/launchpad/schema-distro-parents
- Henning Eggers (community): Approve (code)
- Stuart Bishop (community): Approve (db)
-
Diff: 424 lines (+336/-0)9 files modifieddatabase/schema/comments.sql (+6/-0)
database/schema/patch-2208-61-0.sql (+20/-0)
database/schema/security.cfg (+1/-0)
lib/canonical/launchpad/security.py (+13/-0)
lib/lp/registry/configure.zcml (+16/-0)
lib/lp/registry/interfaces/distroseriesparent.py (+62/-0)
lib/lp/registry/model/distroseriesparent.py (+74/-0)
lib/lp/registry/tests/test_distroseriesparent.py (+132/-0)
lib/lp/testing/factory.py (+12/-0)
lp:~stevenk/launchpad/db-use-dsp
- Stuart Bishop (community): Approve (db)
- Gavin Panella (community): Approve
- Robert Collins: Pending (db) requested
-
Diff: 2228 lines (+462/-377)23 files modifieddatabase/sampledata/current-dev.sql (+3/-3)
database/schema/comments.sql (+1/-0)
database/schema/patch-2208-64-0.sql (+11/-0)
database/schema/security.cfg (+2/-0)
lib/lp/registry/browser/distroseries.py (+28/-9)
lib/lp/registry/browser/distroseriesdifference.py (+1/-0)
lib/lp/registry/browser/tests/test_distroseries.py (+75/-89)
lib/lp/registry/errors.py (+9/-0)
lib/lp/registry/interfaces/distroseriesdifference.py (+13/-3)
lib/lp/registry/model/distroseries.py (+12/-14)
lib/lp/registry/model/distroseriesdifference.py (+31/-25)
lib/lp/registry/scripts/populate_distroseriesdiff.py (+50/-28)
lib/lp/registry/scripts/tests/test_populate_distroseriesdiff.py (+85/-66)
lib/lp/registry/stories/distroseries/xx-distroseries-index.txt (+2/-2)
lib/lp/registry/templates/distroseries-details.pt (+1/-1)
lib/lp/registry/templates/distroseries-localdifferences.pt (+1/-1)
lib/lp/registry/templates/distroseries-portlet-derivation.pt (+2/-2)
lib/lp/registry/templates/distroseriesdifference-listing-extra.pt (+1/-1)
lib/lp/registry/tests/test_distroseries.py (+3/-12)
lib/lp/registry/tests/test_distroseriesdifference.py (+37/-44)
lib/lp/soyuz/model/distroseriesdifferencejob.py (+12/-7)
lib/lp/soyuz/tests/test_distroseriesdifferencejob.py (+68/-65)
lib/lp/testing/factory.py (+14/-5)
Changed in launchpad: | |
status: | New → Triaged |
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → Steve Kowalik (stevenk) |
tags: | added: qa-untestable |
Changed in launchpad: | |
milestone: | 11.05 → 11.06 |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
r10447 in db-stable (http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ db-stable/ revision/ 10447) is part of this bug's fix.