Kung Fu doesn't recover when it can't create a thumbnail

[Tristan Brindle]

That pesky Fight Club DVD again...

Title 60 on this DVD is.... strange. From what I can tell, it seems to be a still image/menu that's reported in the TOC as being 1:02 long. This causes problems with dvdreadsrc*, which refuses to read the track, with the following error:

ERROR kf_gst dvdreadsrc.c(885): gst_dvd_read_src_create (): /pipeline0/dvdreadsrc0
ERROR kf_gst gstbasesrc.c(1569): gst_base_src_loop (): /pipeline0/dvdreadsrc0:
streaming task paused, reason error (-5)

or, with GST_DEBUG=1,dvdreadsrc:5,

0:00:30.917382000 30093 0x747330 INFO dvdreadsrc dvdreadsrc.c:1420:gst_dvd_read_src_goto_sector:<dvdreadsrc0> Seek succeeded, going to chapter 1, cell 0
0:00:30.917394000 30093 0x747330 LOG dvdreadsrc dvdreadsrc.c:359:gst_dvd_read_src_goto_chapter:<dvdreadsrc0> Opened chapter 1 - cell 0-1
0:00:30.917427000 30093 0x747330 LOG dvdreadsrc dvdreadsrc.c:1169:gst_dvd_read_src_do_seek:<dvdreadsrc0> seek to sector 0x0000008c ok
0:00:30.918237000 30093 0x1022320 ERROR dvdreadsrc dvdreadsrc.c:836:gst_dvd_read_src_read:<dvdreadsrc0> Read failed for 0 blocks at 141
ERROR kf_gst dvdreadsrc.c(885): gst_dvd_read_src_create (): /pipeline0/dvdreadsrc0
ERROR kf_gst gstbasesrc.c(1569): gst_base_src_loop (): /pipeline0/dvdreadsrc0:
streaming task paused, reason error (-5)

I think that's a bug in dvdreadsrc; however, it exposes a problem in Kung Fu, namely that it get stuck waiting for the thumbnail routine to return. The "stop reading titles" button doesn't do anything in this situation.

[Tristan Brindle (tristan-brindle)]

(This isn't strictly relevant to the above bug, but it might be interesting from a dvdsrc perspective)

* Just to go into a bit more detail, this title really is interesting.

Acidrip, which uses MPlayer and MEncoder, refuses to preview the title. When trying to encode, it writes a 4kb file (AVI headers?) and exits "sucessfully".

Thoggen refuses to list any tracks higher than 37, which is something I really ought to file.

Baserip (plug! ;-) ) refuses to encode the title, giving the (-5) error. However, my cropping/resizing dialogue does show the initial frame correctly; any attempt to seek gives a (-5) though.

I'd be interested to give this a try with dvdsrc. Does Kung Fu use it automatically, or do I need to use a special bzr branch?

[Jason Gerard DeRose (jderose)]

After testing of more DVDs, I also found a DVD with this same problem. Part of the problem is that through the Python binding I can't get more information about the DVD (which I hope to solve with a 'table-of-contents' signal in dvdsrc).

For me, it seems to be failing on titles with no tmap, but I have no way of knowing this in KungFu (yet). The thing I don't understand is why it worked in the previous, slow pipeline (in say 0.2.1).

Anyway, thanks again for another quality bug report, Tristan. If you wouldn't mind testing this package to see if we finally have this Fight Club DVD working:

http://jasonderose.org/kungfu/releases/kungfu_0.2.3-0ubuntu1_all.deb

Thanks!

[Tristan Brindle (tristan-brindle)]

Yep, works perfectly:

ERROR kf_gst gstbasesrc.c(1569): gst_base_src_loop (): /pipeline0/dvdreadsrc0:
streaming task paused, reason error (-5)
ERROR kf_gst Preroll failed, skipping title 60

Nice one!