Need a complete overlay implementation
Bug #751007 reported by
Paul Hummer
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| phazr |
Fix Committed
|
High
|
Paul Hummer | ||
Bug Description
As we move into more and more overlay polish, it's becoming more and more likely that we'll want to have some sort of decent overlay with all the the plugins we're creating by default. This PhazrOverlay implementation should have the following features:
- Be draggable by its header
- Have a close button in the top right
- React to the ESC button and close
- Close when clicking outside the overlay
- Not get in the way of other plugins
Related branches
lp:~rockstar/phazr/phazr-overlay
- Martin Albisetti (community): Approve
- Deryck Hodge: Pending requested
-
Diff: 156 lines (+63/-6)7 files modifiedexamples/overlay/index.html (+6/-2)
src/css/phazr.css (+4/-0)
src/js/modaloverlay/modaloverlay.js (+14/-2)
src/js/phazroverlay/phazroverlay.js (+6/-0)
tests/index.html (+4/-0)
tests/modaloverlay.js (+5/-2)
tests/phazroverlay.js (+24/-0)
| Changed in phazr: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Paul Hummer (rockstar) |
| Changed in phazr: | |
| milestone: | none → 1.0 |
Revision history for this message
| Paul Hummer (rockstar) wrote | #1 |
| Changed in phazr: | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
Argh, it appears that there's a difference between "plugins" and "extensions" and while I was busy making amazing plugins, I wasn't thinking about using them in the way that I'm using them now. So I guess now I must port every plugin I made to be an extension instead...