Launchpad itself

Spinner for adding/editing/deleting/muting subscriptions

Bug #750561 reported by Benji York
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Gary Poster
Launchpad itself 11.05

Bug Description

Adding/editing/deleting/muting subscriptions does not include an activity indicator (spinner).

We should also add error_handler.clearProgressUI to clear it in make_delete_handler

See original description

Related branches

lp:~gary/launchpad/bug750561
Henning Eggers (community): Approve
Diff: 300 lines (+102/-20)
4 files modified
lib/canonical/launchpad/icing/style.css (+11/-0)
lib/lp/registry/javascript/structural-subscription.js (+22/-5)
lib/lp/registry/javascript/tests/test_structural_subscription.html (+2/-5)
lib/lp/registry/javascript/tests/test_structural_subscription.js (+67/-10)
lp:~gary/launchpad/bug750561-2
Benji York (community): Approve (code)
Diff: 135 lines (+60/-7)
2 files modified
lib/lp/registry/javascript/structural-subscription.js (+19/-5)
lib/lp/registry/javascript/tests/test_structural_subscription.js (+41/-2)
Curtis Hovey (sinzui)
Changed in launchpad:
importance: Undecided → High
status: New → Triaged
Gary Poster (gary)
summary: - Spinner for adding/editing subscriptions
+ Spinner for adding/editing/deleting/muting subscriptions
description: updated
Changed in launchpad:
assignee: nobody → Gary Poster (gary)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r12800 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12800>.

Changed in launchpad:
milestone: none → 11.05
tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → Fix Committed
Revision history for this message
Gary Poster (gary) wrote :

There's a new bug, which is that the add/edit panel closes immediately, before we get a response from the server, so you can't see the spinner, but the code for the spinner is there, tested, and even visible for deletion. I'm going to treat the add/edit closing as a new bug.

tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in db-stable r10421 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/10421>.

tags: added: qa-needstesting
removed: qa-ok
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.