Duplicate lines in logging from SQLAlchemy
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Glance |
Fix Released
|
Low
|
Jay Pipes |
Bug Description
$ glance-registry --log-config=
2011-03-31 17:11:47,016 INFO sqlalchemy.
2011-03-31 17:11:47,017 INFO sqlalchemy.
2011-03-31 17:11:47,017 INFO sqlalchemy.
2011-03-31 17:11:47,017 INFO sqlalchemy.
# cat glance.log
2011-03-31 17:11:47,016 sqlalchemy.
2011-03-31 17:11:47,017 sqlalchemy.
2011-03-31 17:11:47,017 sqlalchemy.
2011-03-31 17:11:47,017 sqlalchemy.
2011-03-31 17:11:47,019 eventlet.
Look explanation here: http://
The echo flags present as keyword arguments to create_engine() and others as well as the echo property on Engine, when set to True, will first attempt to ensure that logging is enabled. Unfortunately, the logging module provides no way of determining if output has already been configured (note we are referring to if a logging configuration has been set up, not just that the logging level is set). For this reason, any echo=True flags will result in a call to logging.
Related branches
- Eldar Nugaev (community): Approve
- Andrey Brindeyev (community): Approve
- Rick Harris (community): Approve
-
Diff: 15 lines (+3/-3)1 file modifiedglance/registry/db/api.py (+3/-3)
Changed in glance: | |
status: | New → Triaged |
importance: | Undecided → Low |
milestone: | none → cactus-2011-04-07 |
Changed in glance: | |
assignee: | nobody → Jay Pipes (jaypipes) |
status: | Triaged → In Progress |
Changed in glance: | |
status: | In Progress → Fix Committed |
Changed in glance: | |
milestone: | cactus-2011-04-07 → 2011.2 |
status: | Fix Committed → Fix Released |