OpenLyrics xml including OpenLP specifics
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenLP |
Fix Released
|
High
|
matysek |
Bug Description
I'll raise this bug here, since we're going to have to do something anyway in OpenLP, but it might need to lead to a wider discussion which would need to spill over into the OpenLyrics group (http://
We're currently exporting tags like {r} and potentially [---] into OpenLyrics XML. We can't do this because other software using will just blindly display this as-is and it will look silly.
Raoul has suggested stripping it, which from the current OpenLyrics point of view is the correct action to take. The problem is, if I want to transfer some of my nicely coloured in songs from one V2 installation to another, and I take the Export Songs route, I'm going to be a little upset that it hasn't taken my {formatting} with it.
Therefore we are going to either need to provide a specific v2 format export which keeps the tags, or we're going to have to suggest to the OpenLyrics group that we can have some form of tag that allows to embed application specific information within the song. e.g. <bespoke app="openlp"
Another option is suggest that OpenLyrics allows strict XHTML to be embedded, and so we just expand the tags and output the expanded information. Collapse again on import if a suitable tag value matches.
However when you have end users entering {r}'s but no {/r}'s or defining their own tags, this is going to be difficult, to enforce.
I think we also need to request a tag for suggested slide break (i.e. try and keep the text on one slide, but if you can't, this is where you should break). e.g. <break suggested="true" />. One for mandatory verse break would be good too <break />, but we already have v1a v1b in OpenLyrics, which I can't say I'm a big fan of since I feel <verse> should ideally contain a whole verse!
Looking at the schema, it could perhaps be an attribute on <line>, e.g. <line suggestedBreak=
Related branches
- Tim Bentley: Needs Fixing
- Andreas Preikschat (community): Needs Fixing
-
Diff: 15 lines (+1/-1)1 file modifiedopenlp/core/ui/servicemanager.py (+1/-1)
- Tim Bentley: Approve
- Raoul Snyman: Approve
- Andreas Preikschat: Pending requested
-
Diff: 902 lines (+404/-116)5 files modifiedopenlp/core/lib/formattingtags.py (+115/-22)
openlp/core/ui/formattingtagform.py (+17/-43)
openlp/core/utils/__init__.py (+5/-0)
openlp/plugins/songs/lib/mediaitem.py (+3/-0)
openlp/plugins/songs/lib/xml.py (+264/-51)
Changed in openlp: | |
status: | New → Confirmed |
Changed in openlp: | |
assignee: | nobody → Andreas Preikschat (googol) |
status: | Confirmed → In Progress |
Changed in openlp: | |
status: | In Progress → Fix Committed |
Changed in openlp: | |
status: | Fix Committed → Fix Released |
See the Mailing List: sourceforge. net/mailarchive /forum. php?thread_ name=4DDBC8B7. 1080209% 40lavabit. com&forum_ name=openlp- devel
http://