floating ip address allocated for project1 can be associated with the instances running for project2

[Tushar Patil]

Tested on revision No. 897

Steps to reproduce this problem:-

1) I have created 2 projects "xyz" and "abc" with project manager "openstack", openstack user is a admin user.
2) I have allocated 2 floating ip address for project "xyz"
root@ubuntu-openstack-network-api-server:/home/tpatil/credentials# euca-describe-addresses
ADDRESS 10.2.3.96 None (xyz)
ADDRESS 10.2.3.97 None (xyz)
3) Then I ran 2 instances, one for each project
root@ubuntu-openstack-network-api-server:/home/tpatil/credentials# euca-describe-instances
RESERVATION r-81vl3jn2 abc default
INSTANCE i-00000003 ami-00000011 10.0.0.3 10.0.0.3 running flat (admin, ubuntu-openstack-compute-01) 0 m1.tiny 2011-03-23T19:03:26Z nova

RESERVATION r-6vtw9sbb xyz default
INSTANCE i-00000004 ami-00000011 10.0.0.19 10.0.0.19 running flat (project2, ubuntu-openstack-compute-01) 0 m1.tiny 2011-03-23T19:04:29Z nova

4) Associate floating ip address 10.2.3.96 for instance "i-00000004" created for project "xyz". This works as expected.

5) Now try to associate floating ip address 10.2.3.97 for instance "i-00000003" created for project "abc", it doesn't give any error message.

Expected Result: floating ip address allocated for a "xyz" project shouldn't be allowed to be associated with the instances created for "abc"project.

I am not sure if this is a specification. But I think it is a bug. Allocation of floating ip address for a particular project is done for some purpose so it shouldn't be allowed to be overridden even by the admin user. First you need to release the floating ip address and then allocate it for different project.

[Tushar Patil (tpatil)]

If this is not a specification, then attached is the patch to fix this problem.