Kung Fu fails to start with no DVD inserted

[Tristan Brindle]

I'm a bug machine at the moment! :)

As per the title, Kung Fu won't start if there is no DVD in the drive. The error is:

  File "dbus_bindings.pyx", line 455, in dbus_bindings.Connection.send_with_reply_and_block
dbus_bindings.DBusException: No property volume.disc.is_videodvd on device with id /org/freedesktop/Hal/devices/volume_part_1_size_586461184

[1]+ Exit 1 kungfu

Seems like it should be easy enough to try/except, I'd whip up a patch for you if I could just work out how to use this Bazaar thing...

[Jason Gerard DeRose (jderose)]

Thanks for another bug report, Tristan!

I thought I had all these cases dealt with, but obviously not. Do you have any (non DVD) disc in your drive? For me KungFu starts fine with an empty drive, but I did just discover that it wont start with a blank CDR disc in the drive.

Bazaar is fairly easy to learn. You can create your own KungFu branch on Lanchpad if you want, which you can write to. Then I can merge fixes into my branch.

Also, I haven't played with the team stuff yet on Launchpad, but I believe I can create a KungFu team. Then I can create a branch that any members of the team can write to. And I'll gladly add you to the team! Let me know if you're interested.

[Jason Gerard DeRose (jderose)]

Oh, if you want to work on this bug, the problem is definitely in KungFu/kf_dbus.py

[Tristan Brindle (tristan-brindle)]

I didn't think of what disc I had in there when I filed the bug report, sorry. I was actually an audio CD. As you say, it does actually start up correctly when the drive is empty, so the title of the bug report is misleading.

I'm afraid I can't commit any time to Kung Fu at the moment as my spare time is taken up with my own project, which is, um, a GStreamer-based DVD ripper, written in Python...

I haven't released any code yet, as the GUI is currently incomplete, but it would be great if we could work together/share code in future. If you're interested in seeing a rough work in progress, drop me an e-mail.

[Jason Gerard DeRose (jderose)]

Turns out this is really a HAL bug, for which I've filed a bug report at https://bugs.launchpad.net/distros/ubuntu/+source/hal/+bug/74540

However, a workaround was very easy. I just pushed a fix to https://launchpad.net/people/jderose/+branch/kungfu/trunk

There is still more I plan to do for 0.2.0, so you'll have to wait a bit for packages that I've built.

Thanks again for the bug report!

[Jason Gerard DeRose (jderose)]

Oh, hehe... I did happen to come across Baserip DVD Ripper in Launchpad a while ago and wondered what you were up to. Good luck.

There might be all sorts of reasons why you want to write your own (for a school project, for the experience, for fame and fortune), but if you find you just want to work on any ol' Python-GStreamer-GNOME DVD ripper, I am happy to share the workload on KungFu! ;)

Other collaboration is of course possible. Also, if you happen to use any KungFu code in your ripper, please to the right thing as far as the license, copyright, etc.

I really recommend using Bazaar for version control even if just for your own local project directory. Bazaar is especially well suited to this.

[Jason Gerard DeRose (jderose)]

I just released 0.2.0, which includes a fix for this bug.

http://jasonderose.org/kungfu/releases/