Cannot delete team with already purges mailing list
Bug #743194 reported by
Curtis Hovey
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Unassigned |
Bug Description
While testing the move the of merge team rules, I discovered there is a defect in the original rules. There are about 30 teams with purged mailing lists that will oops because the mailing list checking rules are including purges lists in the active lists. I believe this one worked, but the checking rules were altered to only look for deactivated lists because users cannot purge lists. The affected teams were purged by ~registry or ~admins members. at the request of users.
Related branches
lp:~sinzui/launchpad/person-merge-job-3
- Curtis Hovey (community): Approve (code)
-
Diff: 44 lines (+18/-5)2 files modifiedlib/lp/registry/model/person.py (+6/-5)
lib/lp/registry/tests/test_person.py (+12/-0)
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Changed in launchpad: | |
assignee: | Curtis Hovey (sinzui) → nobody |
To post a comment you must log in.
Module lp.registry. model.person, line 3860, in merge model.person, line 3815, in _purgeUnmergabl eTeamArtifacts
from_person, to_person, reviewer)
Module lp.registry.
"Teams with active mailing lists cannot be merged.")
AssertionError: Teams with active mailing lists cannot be merged.