Teams can have impossible email addresses
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Unassigned |
Bug Description
A test in my branch revealed that mailing list addresses are not deleted when the mailing list is purged. This does not cause an immediate problem, but it is then possible to rename or merge the team, which will create a mismatch between the teams name and the list address. This can cause issues if another team wants the name that is free. Teams cannot see there is an issue since they can have only one email address; the views will not show the phantom address.
I have a branch that fixes this code issue. The bad email addresses can be deleted from the db when the fix is released.
select t.name, e.email
from person t join emailaddress e on e.person = t.id
where t.teamowner is not null
and e.email like '%launchpad.net'
and e.email not like t.name || '@%'
;
Related branches
- Brad Crittenden (community): Approve (code)
-
Diff: 777 lines (+149/-307)14 files modifiedlib/canonical/launchpad/database/emailaddress.py (+4/-1)
lib/lp/registry/browser/peoplemerge.py (+14/-85)
lib/lp/registry/browser/tests/peoplemerge-views.txt (+1/-18)
lib/lp/registry/browser/tests/test_peoplemerge.py (+0/-52)
lib/lp/registry/doc/mailinglists.txt (+1/-1)
lib/lp/registry/doc/person-merge.txt (+0/-88)
lib/lp/registry/doc/teammembership.txt (+1/-1)
lib/lp/registry/doc/vocabularies.txt (+5/-7)
lib/lp/registry/interfaces/persontransferjob.py (+9/-4)
lib/lp/registry/model/mailinglist.py (+3/-0)
lib/lp/registry/model/person.py (+50/-28)
lib/lp/registry/model/persontransferjob.py (+16/-3)
lib/lp/registry/tests/test_person.py (+42/-18)
lib/lp/registry/tests/test_person_merge_job.py (+3/-1)
Changed in launchpad: | |
status: | In Progress → Fix Committed |
tags: | added: qa-ok |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Changed in launchpad: | |
assignee: | Curtis Hovey (sinzui) → nobody |