HTML is constructed using string concatenation in the structural subscription JS.

Bug #742490 reported by Benji York
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Yellow Squad

Bug Description

Instead of constructing HTML using string operations we should do things like this:

var link = Y.Node.create("<span>See <a /></span>");
link.one("a")
    .set("href", url)
    .set("text", desc);

The code in question is located in lib/lp/registry/javascript/structural-subscription.js

Jonathan Lange (jml)
summary: - HTML is constructed using string concatination in the structural
+ HTML is constructed using string concatenation in the structural
subscription JS.
Curtis Hovey (sinzui)
Changed in launchpad:
status: New → Triaged
importance: Undecided → High
Benji York (benji)
Changed in launchpad:
status: Triaged → In Progress
Benji York (benji)
Changed in launchpad:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.