TagPlayer doesn't start in 11.04 Natty

[zefanja]

TagPlayer crashes if you want to start it in Ubuntu Natty. Here is the log:

** Message: pygobject_register_sinkfunc is deprecated (GstObject)
Traceback (most recent call last):
  File "/usr/bin/tagplayer", line 312, in <module>
    window = TagplayerWindow()
  File "/usr/bin/tagplayer", line 90, in __new__
    new_object.finish_initializing(builder)
  File "/usr/bin/tagplayer", line 141, in finish_initializing
    self.__init_taglib()
  File "/usr/bin/tagplayer", line 241, in __init_taglib
    self.taglib = taglib.TagLib(self.preferences['music_dir'])
  File "/usr/lib/pymodules/python2.7/tagplayer/daemon/taglib.py", line 38, in __init__
    self.music_dir.remove(x)
AttributeError: TagLib instance has no attribute 'music_dir'

[filipe (hikibi)]

I though I released the fix for this already, my bad.

[filipe (hikibi)]

I released it now, can you confirm it is now working?

[zefanja (zefanja)]

No, it is not working. There is no error message but it doesn't start.

I'm using german as my default language and so there is no directory "Music" (it's called "Musik" in german). If I add a "Music directory Tagplayer is working without problems.

Version: 0.2.09-daily~r52~natty1

[zefanja (zefanja)]

There seems to be a new problem: I could start TagPlayer one time, change the music directory, but if I want to start it again I get this error:

Traceback (most recent call last):
  File "/usr/bin/tagplayer", line 312, in <module>
    window = TagplayerWindow()
  File "/usr/bin/tagplayer", line 90, in __new__
    new_object.finish_initializing(builder)
  File "/usr/bin/tagplayer", line 141, in finish_initializing
    self.__init_taglib()
  File "/usr/bin/tagplayer", line 241, in __init_taglib
    self.taglib = taglib.TagLib(self.preferences['music_dir'])
  File "/usr/lib/pymodules/python2.7/tagplayer/daemon/taglib.py", line 36, in __init__
    self.__b[x] = Builder(x,self)
  File "/usr/lib/pymodules/python2.7/tagplayer/daemon/builder.py", line 34, in __init__
    self.complete = self.__load_library()
  File "/usr/lib/pymodules/python2.7/tagplayer/daemon/builder.py", line 43, in __load_library
    library = json.load(fp)
  File "/usr/lib/python2.7/json/__init__.py", line 278, in load
    **kw)
  File "/usr/lib/python2.7/json/__init__.py", line 326, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python2.7/json/decoder.py", line 360, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python2.7/json/decoder.py", line 376, in raw_decode
    obj, end = self.scan_once(s, idx)
ValueError: Expecting : delimiter: line 31928 column 5 (char 2043925)

Kernel: 2.6.38-7-generic-pae
Version: 0.2.09-daily~r52~natty1
Python 2.7.1+ (r271:86832, Mar 24 2011, 00:39:14)

[filipe (hikibi)]

First of all, thanks for the bug reports, they are very helpful to find stuff I overlooked.

Concerning the music dir name I used 'Music' since I work with a english setting and I don't know the proper way to access the music folder in ubuntu programatically. I will include a translation workaround (not the best solution, but it will have to do while I don't figure the proper way out) in the next version to try to fix the issue.

To understand the second error I need a little more information:
- How did you change the music dir, in TagPlayer?
- If there are any .tagplayer_library_randomnumber files in your home folder please attach them, this error happens when reading one of them, so there must be something wrong there.

I will try to correct these and have the fixes in the next daily package.

[filipe (hikibi)]

The problem should be fixed in the latest daily package (r53). Please try it out and give me feedback.