application/pdf button popping up the whole document

[Uday Reddy]

When a button is meant to be displayed for application/pdf, the whole document is being displayed in a separate window! The backtrace shows

  vm-decode-mime-layout(#<overlay from 5697 to 5698 in test-mime Presentation> t)
  vm-mime-display-generic(#<overlay from 5697 to 5698 in test-mime Presentation>)
  vm-mime-frob-image-xxxx(#<overlay from 5697 to 5698 in test-mime Presentation> "-thumbnail" "80x80")
  vm-mime-display-button-image([("image/png") ("application/pdf" "name=\"College newsletter - contributor guidance.doc.pdf\"") "base64" nil "College newsletter - contributor guidance.doc.pdf" ("attachment" "filename=College newsletter - contributor guidance.doc.pdf" "size=96184" "creation-date=Mon, 20 Dec 2010 13:01:23 GMT" "modification-date=Mon, 20 Dec 2010 13:01:23 GMT") ("attachment" "filename=\"College newsletter - contributor guidance.doc.pdf\"" "size=96184" "creation-date=\"Mon, 20 Dec 2010 13:01:23 GMT\"" "modification-date=\"Mon, 20 Dec 2010 13:01:23 GMT\"") #<marker at 1844131 in test-mime> #<marker at 1844532 in test-mime> #<marker at 1844533 in test-mime> #<marker at 1974469 in test-mime> nil <<c>> <<m>> nil nil nil])
* vm-mime-display-button-application/pdf([("image/png") ("application/pdf" "name=\"College newsletter - contributor guidance.doc.pdf\"") "base64" nil "College newsletter - contributor guidance.doc.pdf" ("attachment" "filename=College newsletter - contributor guidance.doc.pdf" "size=96184" "creation-date=Mon, 20 Dec 2010 13:01:23 GMT" "modification-date=Mon, 20 Dec 2010 13:01:23 GMT") ("attachment" "filename=\"College newsletter - contributor guidance.doc.pdf\"" "size=96184" "creation-date=\"Mon, 20 Dec 2010 13:01:23 GMT\"" "modification-date=\"Mon, 20 Dec 2010 13:01:23 GMT\"") #<marker at 1844131 in test-mime> #<marker at 1844532 in test-mime> #<marker at 1844533 in test-mime> #<marker at 1974469 in test-mime> nil <<c>> <<m>> nil nil nil])

[Uday Reddy (reddyuday)]

This problem is not there in 8.1.93a.

[Uday Reddy (reddyuday)]

The problem may be with images in general. All images seem to be getting auto-displayed.

[Uday Reddy (reddyuday)]

It works in 8.1.93a by accident. It is assumed there that the internal display of the image will work. If it doesn't, nothing more is done, whereas an external viewer should be tried.

[Uday Reddy (reddyuday)]

The function vm-mime-display-generic used for displaying thumbnails tries both internal and external viewers.

Fixed in revision 1159.