wrong local variable name in VMOPS._shutdown causes termination to fail

[Salvatore Orlando]

It is currently not possible to successfully terminate XenAPI instances due to a misnamed local variable in vmops.py:

Correct variable name is vm_ref.

 def _shutdown(self, instance, vm_ref, hard=True):
        """Shutdown an instance"""
        state = self.get_info(instance['name'])['state']
        if state == power_state.SHUTDOWN:
---> LOG.warn(_("VM %(vm)s already halted, skipping shutdown...") % <---
                     locals())

[Salvatore Orlando (salvatore-orlando)]

A recent merge solved the issue.
The following code is now in trunk:

        if state == power_state.SHUTDOWN:
            instance_name = instance.name
            LOG.warn(_("VM %(instance_name)s already halted,"
                    "skipping shutdown...") % locals())
            return

I'd love to change the bug status... Invalid or Fix Committed?

Merge proposal has been put on hold. Will delete once the bug status is changed.