deleteLocalRoles times out

[sureshvv]

For a large site with a lot of content, deleteLocalRoles may take a long time and the database connection times out. This can be fixed with a "transaction.commit()" in the loop.

Will be happy to commit the change if approved.

[Raphael Ritz (raphael-ritz)]

Wouldn't it be better to set a savepoint (optimistic=True) rather than doing a full commit?
Would that work as well?

Raphael

[Hedley (hedley-upfrontsystems)]

How does the database connection time out? I'm expecting the browser to time out.

The only reason why the periodic commits seem to prevent timeouts is because it reduces the overall running time required to do deleteLocalRoles. This is expected since periodic commits in such a for-loop reduce overall memory consumption (at the risk of inconsistent data should an error occur during later iterations).

So it is not a global fix. There are a few strategies to handle such a case and they all relate to deferring the heavy operations (thread, cron job etc).

[Wichert Akkerman (wichert)]

Perhaps it helps prevent ConflictErrors, and thus retries.

[sureshvv (sureshvv)]

> How does the database connection time out? I'm expecting the browser to time out.

Browser times out sometimes. Database "Connection timed out" happens even before.

> So it is not a global fix.

Agree. Improved things slightly for me. Otherwise the ZEO client becomes useless and needs to be restarted. But will investigate better fix.