Consolidate locking mechanisms
Bug #739763 reported by
Vish Ishaya
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Compute (nova) |
Fix Released
|
Medium
|
Soren Hansen | ||
Bug Description
We're currently using a couple of different locking mechanisms to prevent race conditions:
semaphores (linux_net and libvirt_conn)
utils.synchronized
They should be combined into one strategy, either using file locks for everything, or by allowing a parameer to synchronized telling it whether to use a semaphore or a file lock.
It may be useful to check all the places we are using threadpools to make sure that they shouldn't also be using a shared locking mechanism instead.
Related branches
lp:~soren/nova/consolidate-locking
- Rick Harris (community): Approve
- Vish Ishaya (community): Approve
-
Diff: 305 lines (+134/-51)5 files modifiednova/network/linux_net.py (+16/-25)
nova/tests/test_misc.py (+39/-4)
nova/tests/test_virt.py (+0/-2)
nova/utils.py (+67/-7)
nova/virt/libvirt_conn.py (+12/-13)
| Changed in nova: | |
| status: | New → Triaged |
| assignee: | nobody → Soren Hansen (soren) |
| Changed in nova: | |
| status: | Triaged → In Progress |
| importance: | Undecided → Medium |
| Changed in nova: | |
| status: | In Progress → Fix Committed |
| Changed in nova: | |
| milestone: | none → 2011.2 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
