DistributionSourcePackage:+publishinghistory timeouts
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
William Grant | ||
Bug Description
5 SELECT SourcePackagePu
GET: 3 Other: 2 Robots: 0 Local: 1
3 https:/
OOPS-1904E640, OOPS-1904F844, OOPS-1904H2023
1 https:/
OOPS-1904D305
1 https:/
OOPS-1904G293
See bug 758258 for some issues related to the schema that might help this timeout.
Related branches
- Curtis Hovey (community): Approve (code)
-
Diff: 583 lines (+129/-117)15 files modifiedlib/lp/registry/browser/distributionsourcepackage.py (+25/-8)
lib/lp/registry/browser/tests/test_distributionsourcepackage.py (+33/-2)
lib/lp/registry/doc/distroseries.txt (+5/-14)
lib/lp/registry/model/distributionsourcepackage.py (+19/-17)
lib/lp/services/database/decoratedresultset.py (+3/-1)
lib/lp/soyuz/browser/distributionsourcepackagerelease.py (+5/-1)
lib/lp/soyuz/doc/sourcepackagerelease-build-lookup.txt (+3/-4)
lib/lp/soyuz/doc/soyuz-upload.txt (+1/-1)
lib/lp/soyuz/interfaces/distroseriessourcepackagerelease.py (+0/-3)
lib/lp/soyuz/model/distributionsourcepackagerelease.py (+16/-23)
lib/lp/soyuz/model/distroseriessourcepackagerelease.py (+11/-39)
lib/lp/soyuz/stories/ppa/xx-delete-packages.txt (+1/-0)
lib/lp/soyuz/stories/soyuz/xx-distributionsourcepackagerelease-pages.txt (+1/-0)
lib/lp/soyuz/templates/distributionsourcepackage-portlet-pub-details.pt (+2/-2)
lib/lp/soyuz/templates/distributionsourcepackage-publishinghistory.pt (+4/-2)
| summary: |
- DistributionSourcePackage:+publishinghistory + DistributionSourcePackage:+publishinghistory timeouts |
| description: | updated |
| Colin Watson (cjwatson) wrote | #1 |
| Changed in launchpad: | |
| assignee: | nobody → William Grant (wgrant) |
| status: | Triaged → In Progress |
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
Somebody reminded me recently that ages ago I had objected to +publishinghistory being batched, IIRC on the grounds that that made it unsearchable. For the record, I no longer think that this is a sensible objection: we have other tools to get full history if we need to, and in any event a page that times out due to having to render way too much data is clearly less useful than one that manages to display something. As Ubuntu gets older, +publishinghistory for important packages gets longer and longer, and this becomes incrementally more of a problem.
So, if batching would help - and I suspect it would, certainly for the packages in question - consider my objection withdrawn.